Enable minimal testing with windows and macOS #215
Conversation
|
@gaborbernat I am unable to test this change because I cannot create branches in tox-uv itself and GHA pipeline changes run only on local PRs, not the ones from forks. Can you please give a hand with this? Thanks. Here is PR I made with the same code on my branch https://github.com/ssbarnea/tox-uv/actions/runs/15777559807/job/44475364088?pr=2 If you want I can remove the pull_request_target from it. As you can see we have 3 broken Windows tests, which proves the need for platform testing. As a first stage I would probably add a conditional xfail to them to allow the testing to be abled, and fix them after. Sounds ok to you? |
ssbarnea
force-pushed
the
chore/test-os
branch
5 times, most recently
from
50f9a8f to
a8f17ea
Compare
Ok. |
ssbarnea
force-pushed
the
chore/test-os
branch
5 times, most recently
from
87fcab2 to
352ef5e
Compare
ssbarnea
changed the title
ssbarnea
force-pushed
the
chore/test-os
branch
6 times, most recently
from
a72ae90 to
1e15c31
Compare
Due to the specific nature of how uv works, some minimal testing on Windows and MacOS would be needed. Related: tox-dev#193 tox-dev#183
|
@gaborbernat I finally made it pass CI. I had to use "xfail" on some broken tests as they are not fixable by us. I fixed few minor issues with existing ones. Once this goes in we will be able to gradually address these bugs. Please let me know what I need to change to close this one. Thanks. |
| project = tox_project({"tox.ini": f"[testenv]\npackage=skip\nbase_python={other_interpreter_exe}"}) | ||
| result = project.run("-vv") | ||
| result.assert_success() | ||
|
|
||
|
|
||
| @pytest.mark.xfail( | ||
| sys.platform == "win32", | ||
| reason="Bug https://github.com/tox-dev/tox-uv/issues/193 https://github.com/astral-sh/uv/issues/14239", |
There was a problem hiding this comment.
We are not using pypy, so how come this happens?
Due to the specific nature of how uv works, some minimal testing on Windows and MacOS would be needed.
Related: #193 #183
Related: astral-sh/uv#14239