-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symmetric positive definite domain #6
Comments
I will add one (perhaps in the examples on how to use |
I have a model where the prior is inverse Wishart. |
I added it as a test/example. I will think about adding it as a regular transform, but I don't think Wishart is a good prior, so I would rather encourage using half-Cauchy for standard deviations and LKJ for the correlation matrix (apologies if you know about this and decided you still need Wishart). |
I agree, but i'm replicating someone else's results. |
and thanks for the example! |
@simonbyrne: just to let you know, I am merging an API change now. I have updated the example in the tests. If you are using this library in production, you may want to pin to df4234b, or update your code. As the library is currently in development and I am experimenting, there will be no deprecations or releases until it stabilizes. So you may want to use Github's watch functionality for notifications. |
No problem, thanks for the heads up.
|
+1 to please add this. I don't think preference against the Inverse Wishart prior is a strong reason not to include this transform - appropriateness of the Wishart/IW prior depends on the user's likelihood. I'm using a Wishart it for estimating a symmetric positive definite matrix that isn't a covariance (i.e. my likelihood is not multivariate Gaussian with unknown Sigma or anything remotely near), where LKJ is not necessarily appropriate, and Wishart with identity hyperparameter is a natural choice due to its group invariance properties. |
So would you need a transformation from an |
Yes - just as in Stan - this would be fantastic! |
Could you add a symmetric positive definite domain transformation? It could be based on the correlation one.
The text was updated successfully, but these errors were encountered: