use EditText to input the price/quantity

Author: gigiyy

exampleAppJapan/src/main/kotlin/it/trade/android/japanapp/ui/orderinput/OrderInputFragment.kt

@@ -2,7 +2,6 @@ package it.trade.android.japanapp.ui.orderinput
 
 import android.arch.lifecycle.Observer
 import android.arch.lifecycle.ViewModelProviders
-import android.opengl.Visibility
 import android.os.Bundle
 import android.support.v4.app.Fragment
 import android.text.Editable
@@ -13,7 +12,6 @@ import android.view.ViewGroup
 import android.widget.EditText
 import it.trade.android.japanapp.R
 import kotlinx.android.synthetic.main.order_input_fragment.*
-import kotlinx.android.synthetic.main.order_input_fragment.view.*
 
 class OrderInputFragment : Fragment() {
 
@@ -85,6 +83,26 @@ class OrderInputFragment : Fragment() {
             viewModel.setLimitOrder()
             togglePriceType()
         }
+        etPrice.onChange { price ->
+            val selection = etPrice.selectionStart
+            val result = viewModel.setLimitPrice(price)
+            etPrice.error = null
+            if (!result) {
+                etPrice.error = getString(R.string.invalid_price)
+            } else if (selection >= 0) {
+                etPrice.setSelection(selection)
+            }
+        }
+        etQuantity.onChange { quantity ->
+            val selection = etQuantity.selectionStart
+            val result = viewModel.setQuantity(quantity)
+            etQuantity.error = null
+            if (!result) {
+                etQuantity.error = getString(R.string.invalid_quantity)
+            } else if (selection >= 0) {
+                etQuantity.setSelection(selection)
+            }
+        }
     }
 
     private fun togglePriceType() {
@@ -97,7 +115,7 @@ class OrderInputFragment : Fragment() {
         }
     }
 
-    fun EditText.onChange(cb: (String) -> Unit) {
+    private fun EditText.onChange(cb: (String) -> Unit) {
         this.addTextChangedListener(object : TextWatcher {
             override fun afterTextChanged(s: Editable?) {
                 cb(s.toString())

exampleAppJapan/src/main/kotlin/it/trade/android/japanapp/ui/orderinput/OrderInputViewModel.kt

@@ -65,6 +65,52 @@ class OrderInputViewModel(private val symbol: String) : ViewModel() {
             orderInfo = orderInfo.copy(type = OrderType.LIMIT)
         }
     }
+
+    fun setLimitPrice(price: String): Boolean {
+        val newPrice = try {
+            price.toDouble()
+        } catch (e: NumberFormatException) {
+            return false
+        }
+        if (newPrice == orderForm.value?.orderInfo?.limitPrice) {
+            // to avoid infinite loop, don't update model when value is not actually updated
+            return true
+        }
+        var isValid = false
+        val newValue = orderForm.value?.apply {
+            if (newPrice >= symbol.priceLowerLimit && newPrice <= symbol.priceUpperLimit) {
+                orderInfo = orderInfo.copy(limitPrice = newPrice)
+                isValid = true
+            }
+        }
+        if (isValid){
+            orderForm.value = newValue
+        }
+        return isValid
+    }
+
+    fun setQuantity(quantity: String): Boolean {
+        val newQuantity = try {
+            quantity.toInt()
+        } catch (e: NumberFormatException) {
+            return false
+        }
+        if (newQuantity == orderForm.value?.orderInfo?.quantity) {
+            // to avoid infinite loop, don't update model when value is not actually updated
+            return true
+        }
+        var isValid = false
+        val newValue = orderForm.value?.apply {
+            if (newQuantity % symbol.lotSize == 0) {
+                orderInfo = orderInfo.copy(quantity = newQuantity)
+                isValid = true
+            }
+        }
+        if (isValid) {
+            orderForm.value = newValue
+        }
+        return isValid
+    }
 }
 
 class OrderInputViewModelFactory(private val symbol: String) : ViewModelProvider.NewInstanceFactory() {

exampleAppJapan/src/main/res/layout/order_input_fragment.xml

@@ -150,9 +150,10 @@
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:layout_marginTop="8dp"
-                android:ems="6"
+                android:ems="8"
                 android:inputType="number"
                 android:textAlignment="center"
+                android:selectAllOnFocus="true"
                 app:layout_constraintEnd_toStartOf="@+id/btQuantityPlus"
                 app:layout_constraintStart_toEndOf="@+id/btQuantityMinus" />
 
@@ -253,9 +254,10 @@
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
                     android:layout_marginTop="8dp"
-                    android:ems="6"
+                    android:ems="8"
                     android:inputType="number"
                     android:textAlignment="center"
+                    android:selectAllOnFocus="true"
                     app:layout_constraintEnd_toStartOf="@+id/btPricePlus"
                     app:layout_constraintStart_toEndOf="@+id/btPriceMinus" />
 

exampleAppJapan/src/main/res/values/strings.xml

@@ -16,4 +16,6 @@
     <string name="general">一般</string>
     <string name="nisa">NISA</string>
     <string name="order_review">注文内容の確認へ</string>
+    <string name="invalid_price">指定価格が値幅制限以内にしてください。</string>
+    <string name="invalid_quantity">指定株数をロットサイズの整数倍にしてください</string>
 </resources>