-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build script with chosen connectors #528
Comments
would that be a shell script to run the [Dockerfile| https://github.com/transferwise/pipelinewise/blob/master/Dockerfile] and passing a list of connectors to build only the certain components into the image? Sounds like a nice feature, please go ahead and waiting for the PR :) |
Yep, I'm actually imagining a few other improvements down the line: What do you think @koszti? |
that sounds amazing really! |
@koszti may I also suggest we add a CI script that just takes common tap-target pairs, builds and pushes multiple images Just so we can have standard images to let people get up to speed faster with the project. We can even iterate on all the supported taps and targets and build the permutations if we really want to... |
@koszti ? |
hey @amigold, do you mean to start publishing standard, official public docker pipelinewise images automatically to dockerhub for example? |
Yes exactly @koszti |
makes sense, we will discuss it internally in the team and will come back soon with answers. 🙇♂️ |
Ok |
Hi guys! great idea btw @amigold. And then I think it will be great if we could do it natively, so I created the Kubernetes operator https://github.com/dirathea/pipelinewise-operator (it still WIP btw) to simplify the setup process. And those apps will get a huge advantage if there's an official Docker image for Pipelinewise |
Nice one @dirathea ! Great idea Which sources/targets do you currently support? |
Also I think you should use secrets to store the credentials |
I planned to have all the default connection to be supported out of the box. The master password as Kubernetes secret also not supported yet, but I think the operator will only access it. The user itself needs to create it manually beforehand. |
Subject of the issue
I would like to add a bash script to build a docker image that only includes chosen connectors and not default to "all"
The script will ask the user for connectors and output tag and then run the docker build command
May I submit a PR?
The text was updated successfully, but these errors were encountered: