show emails in executions endpoint (#1165)

Author: piotrmilcarz

lib/travis/api/v3/renderer/user.rb

@@ -6,11 +6,11 @@ class Renderer::User < Renderer::Owner
     representation(:additional, :emails)
 
     def email
-      @model.email if current_user?
+      @model.email if show_emails?
     end
 
     def emails
-      current_user? ? @model.emails.map(&:email) : []
+      show_emails? ? @model.emails.map(&:email) : []
     end
 
     def secure_user_hash
@@ -20,6 +20,10 @@ def secure_user_hash
 
     private
 
+    def show_emails?
+      current_user? || options[:show_email] == true
+    end
+
     def current_user?
       access_control.class == Travis::API::V3::AccessControl::LegacyToken && access_control.user.id == @model.id
     end

lib/travis/api/v3/services/executions/for_owner_per_sender.rb

@@ -31,7 +31,7 @@ def recuce_by_sender(results) # rubocop:disable Metrics/AbcSize, Metrics/MethodL
             credits_consumed: item.credits_consumed,
             minutes_consumed: minutes_consumed,
             sender_id: item.sender_id,
-            sender: Renderer.render_model(sender, mode: :standard)
+            sender: Renderer.render_model(sender, mode: :standard, show_email: true)
           }
         end
       end

spec/v3/services/v2_subscription/executions_spec.rb

@@ -170,7 +170,7 @@
                 "@representation"=>"minimal",
                 "id"=>1
               },
-              "email"=>nil,
+              "email"=>"[email protected]",
               "is_syncing"=>nil,
               "synced_at"=>nil,
               "recently_signed_up"=>false,