Skip to content

Move the global variables to Terminal #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
easeway opened this issue Mar 23, 2016 · 1 comment
Open

Move the global variables to Terminal #3

easeway opened this issue Mar 23, 2016 · 1 comment

Comments

@easeway
Copy link

easeway commented Mar 23, 2016

This is cool piece. It will great if the following global variables can be moved to Terminal struct:

var (
    InputFD int       = unix.Stdin
    Input   io.Reader = os.Stdin
    Output  io.Writer = os.Stdout
)

I'm running this library with a few off screen terminal emulators, global variables doesn't work for me.

@easeway
Copy link
Author

easeway commented Mar 23, 2016

I can help refactoring the code if you don't have time to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant