Merge pull request #623 from Crozzers/allow-plus-sign-in-urls

nicholasserra · web-flow · commit 1e002580180a · 2025-03-19T18:03:43.000-04:00
Don't escape plus signs in URLs (#621)
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,7 @@
 
 - [pull #617] Add MarkdownFileLinks extra (#528)
 - [pull #622] Add missing block tags to regex (#620)
+- [pull #623] Don't escape plus signs in URLs (#621)
 
 
 ## python-markdown2 2.5.3
diff --git a/lib/markdown2.py b/lib/markdown2.py
@@ -4099,8 +4099,6 @@ def _html_escape_url(
         .replace('<', '&lt;')
         .replace('>', '&gt;'))
     if safe_mode:
-        if charset != 'base64':
-            escaped = escaped.replace('+', ' ')
         escaped = escaped.replace("'", "&#39;")
     return escaped
 
diff --git a/test/tm-cases/safe_mode_issue621.html b/test/tm-cases/safe_mode_issue621.html
@@ -0,0 +1 @@
+<p><a href="https://chromium.googlesource.com/v8/v8.git/+/refs/heads/beta">Chromium</a></p>
diff --git a/test/tm-cases/safe_mode_issue621.opts b/test/tm-cases/safe_mode_issue621.opts
@@ -0,0 +1 @@
+{'safe_mode': 'escape'}
diff --git a/test/tm-cases/safe_mode_issue621.text b/test/tm-cases/safe_mode_issue621.text
@@ -0,0 +1 @@
+[Chromium](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/beta)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<p><a href="https://chromium.googlesource.com/v8/v8.git/+/refs/heads/beta">Chromium</a></p>`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+[Chromium](https://chromium.googlesource.com/v8/v8.git/+/refs/heads/beta)`