record when the batch processing is completed

Author: ericallam

apps/webapp/app/presenters/v3/BatchPresenter.server.ts

@@ -24,6 +24,7 @@ export class BatchPresenter extends BasePresenter {
         updatedAt: true,
         completedAt: true,
         processingStartedAt: true,
+        processingCompletedAt: true,
         successfulRunCount: true,
         failedRunCount: true,
         idempotencyKey: true,
@@ -96,6 +97,7 @@ export class BatchPresenter extends BasePresenter {
       updatedAt: batch.updatedAt.toISOString(),
       completedAt: batch.completedAt?.toISOString(),
       processingStartedAt: batch.processingStartedAt?.toISOString(),
+      processingCompletedAt: batch.processingCompletedAt?.toISOString(),
       finishedAt: batch.completedAt
         ? batch.completedAt.toISOString()
         : hasFinished

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.batches.$batchParam/route.tsx

@@ -189,6 +189,14 @@ export default function Page() {
                   </Property.Value>
                 </Property.Item>
               )}
+              {batch.processingCompletedAt && (
+                <Property.Item>
+                  <Property.Label>Processing completed</Property.Label>
+                  <Property.Value>
+                    <DateTime date={batch.processingCompletedAt} />
+                  </Property.Value>
+                </Property.Item>
+              )}
               <Property.Item>
                 <Property.Label>Finished</Property.Label>
                 <Property.Value>

apps/webapp/app/routes/api.v2.batches.$batchId.ts

@@ -36,17 +36,21 @@ export const loader = createLoaderApiRoute(
       idempotencyKey: batch.idempotencyKey ?? undefined,
       createdAt: batch.createdAt,
       updatedAt: batch.updatedAt,
+      processingCompletedAt: batch.processingCompletedAt ?? undefined,
       runCount: batch.runCount,
       runs: batch.runIds,
-      processingErrors:
-        batch.errors.length > 0
-          ? batch.errors.map((err) => ({
-              index: err.index,
-              taskIdentifier: err.taskIdentifier,
-              error: err.error,
-              errorCode: err.errorCode ?? undefined,
-            }))
-          : undefined,
+      processing: {
+        completedAt: batch.processingCompletedAt ?? undefined,
+        errors:
+          batch.errors.length > 0
+            ? batch.errors.map((err) => ({
+                index: err.index,
+                taskIdentifier: err.taskIdentifier,
+                error: err.error,
+                errorCode: err.errorCode ?? undefined,
+              }))
+            : [],
+      },
     });
   }
 );

apps/webapp/app/v3/runEngine.server.ts

@@ -312,6 +312,7 @@ function setupBatchQueueCallbacks(engine: RunEngine) {
           successfulRunCount,
           failedRunCount,
           completedAt: status === "ABORTED" ? new Date() : undefined,
+          processingCompletedAt: new Date(),
         },
       });
 

internal-packages/database/prisma/migrations/20251209155209_add_processing_completed_at_to_batch_task_run/migration.sql

@@ -0,0 +1,2 @@
+-- AlterTable
+ALTER TABLE "public"."BatchTaskRun" ADD COLUMN     "processingCompletedAt" TIMESTAMP(3);

internal-packages/database/prisma/schema.prisma

@@ -1571,13 +1571,15 @@ model BatchTaskRun {
 
   // Run Engine v2 batch queue fields
   /// When processing started (status changed to PROCESSING)
-  processingStartedAt DateTime?
+  processingStartedAt   DateTime?
+  /// When processing completed (all items processed)
+  processingCompletedAt DateTime?
   /// Count of successfully created runs
-  successfulRunCount  Int?
+  successfulRunCount    Int?
   /// Count of failed run creations
-  failedRunCount      Int?
+  failedRunCount        Int?
   /// Detailed failure records
-  errors              BatchTaskRunError[]
+  errors                BatchTaskRunError[]
 
   ///all the below properties are engine v1 only
   items                  BatchTaskRunItem[]

packages/core/src/v3/schemas/api.ts

@@ -1219,14 +1219,17 @@ export const RetrieveBatchV2Response = z.object({
   updatedAt: z.coerce.date(),
   runCount: z.number(),
   runs: z.array(z.string()),
-  processingErrors: z.array(
-    z.object({
-      index: z.number(),
-      taskIdentifier: z.string(),
-      error: z.string(),
-      errorCode: z.string().optional(),
-    })
-  ),
+  processing: z.object({
+    completedAt: z.coerce.date().optional(),
+    errors: z.array(
+      z.object({
+        index: z.number(),
+        taskIdentifier: z.string(),
+        error: z.string(),
+        errorCode: z.string().optional(),
+      })
+    ),
+  }),
 });
 
 export type RetrieveBatchV2Response = z.infer<typeof RetrieveBatchV2Response>;

packages/trigger-sdk/src/v3/batch.ts

@@ -5,12 +5,13 @@ import {
   ApiRequestOptions,
   mergeRequestOptions,
   RetrieveBatchResponse,
+  RetrieveBatchV2Response,
 } from "@trigger.dev/core/v3";
 import {
+  batchTriggerAndWaitTasks,
   batchTriggerById,
   batchTriggerByIdAndWait,
   batchTriggerTasks,
-  batchTriggerAndWaitTasks,
 } from "./shared.js";
 import { tracer } from "./tracer.js";
 
@@ -42,7 +43,7 @@ export const batch = {
 function retrieveBatch(
   batchId: string,
   requestOptions?: ApiRequestOptions
-): ApiPromise<RetrieveBatchResponse> {
+): ApiPromise<RetrieveBatchV2Response> {
   const apiClient = apiClientManager.clientOrThrow();
 
   const $requestOptions = mergeRequestOptions(

references/hello-world/src/trigger/batches.ts

@@ -1,4 +1,4 @@
-import { batch, task } from "@trigger.dev/sdk/v3";
+import { batch, logger, task } from "@trigger.dev/sdk/v3";
 import { setTimeout } from "timers/promises";
 
 export const batchTriggerAndWait = task({
@@ -207,11 +207,17 @@ export const largePayloadBatch = task({
     }
 
     // Trigger the batch - large payloads are automatically offloaded to R2
-    const result = await largePayloadTask.batchTriggerAndWait(generateLargeItems());
+    const result = await largePayloadTask.batchTrigger(generateLargeItems());
+
+    await setTimeout(5000);
+
+    const myBatch = await batch.retrieve(result.batchId);
+
+    logger.info("batch", { myBatch });
 
     return {
-      batchId: result.id,
-      runCount: result.runs.length,
+      batchId: result.batchId,
+      runCount: result.runCount,
       payloadSizeKB: sizeKB,
       note: `Each payload was ~${sizeKB}KB. Payloads over 512KB are offloaded to R2.`,
     };