Skip to content

Bug: RequestLoggerController concurrency errors #165

Open
@mosiac1

Description

@mosiac1

RequestLoggerController uses EvictingQueue from Guava, which is not thread-safe, so you end up with errors such as:

java.util.NoSuchElementException
	at java.base/java.util.ArrayDeque.removeFirst(ArrayDeque.java:361)
	at java.base/java.util.ArrayDeque.remove(ArrayDeque.java:522)
	at com.google.common.collect.EvictingQueue.add(EvictingQueue.java:111)
	at io.trino.aws.proxy.server.rest.RequestLoggerController.logAndClear(RequestLoggerController.java:307)

Which are likely caused by the queue going into a bad state.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions