Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including web-ui properties in additionalConfigProperties causes worker pods to crash #302

Open
mcowart123 opened this issue Feb 12, 2025 · 2 comments

Comments

@mcowart123
Copy link

The following additionalProperties:

additionalConfigProperties:
    - http-server.process-forwarded=true
    - web-ui.authentication.type=oauth2
    - web-ui.preview.enabled=true
    - http-server.authentication.type=oauth2
    - http-server.authentication.oauth2.issuer=<REDACTED>
    - http-server.authentication.oauth2.client-id=6<REDACTED>
    - http-server.authentication.oauth2.client-secret=<REDACTED>
    - internal-communication.shared-secret=<REDACTED>

cause the worker pod to fail with the following:

2025-02-12T03:02:20.044Z	ERROR	main	io.trino.server.Server	Configuration is invalid
==========

Errors:

1) Configuration property 'web-ui.authentication.type' was not used
2) Configuration property 'web-ui.preview.enabled' was not used

Per this issue this is expected behavior as web-ui config properties are not allowed in worker configs. The UI is working fine with OpenID.

There needs to be a way to specify independent additionalConfigProperties for the coordinator/workers and not force everything into one that applies to both (I tried doing that myself by moving it under each one but nothing was applied at all that way).

@mcowart123 mcowart123 changed the title Adding web-ui properties to additionalConfigProperties causes worker pods to crash Including web-ui properties in additionalConfigProperties causes worker pods to crash Feb 12, 2025
@mcowart123
Copy link
Author

Submitted #303 for review.

@mcowart123
Copy link
Author

I don't have time to solve/work on this myself; the core issue still needs resolved though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant