Skip to content

Commit 454cc5e

Browse files
committed
remove complicated qos test
1 parent b2dabdb commit 454cc5e

File tree

6 files changed

+108
-680
lines changed

6 files changed

+108
-680
lines changed

lints/par_iter/Cargo.toml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,6 @@ path = "ui/main.rs"
3232
name = "par_iter_main2"
3333
path = "ui/main2.rs"
3434

35-
[[example]]
36-
name = "qos"
37-
path = "ui/qos.rs"
38-
3935
[lints.clippy]
4036
# GROUPS
4137
perf = { level = "warn", priority = -1 }

lints/par_iter/ui/main.fixed

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@ struct Pantheon {
2020
tasks: Vec<String>,
2121
}
2222

23+
#[derive(Debug, PartialEq)]
24+
struct Case {
25+
uid: u32,
26+
mode: u32,
27+
priority: u32,
28+
}
29+
2330
fn main() {}
2431

2532
// should parallelize
@@ -268,3 +275,46 @@ fn mut_var_declared_in_closure() {
268275
.collect();
269276
println!("{:?}", doubled_numbers);
270277
}
278+
279+
// no
280+
fn request_request_filter() {
281+
let case = Case {
282+
uid: 1,
283+
mode: 10,
284+
priority: 20,
285+
};
286+
287+
let high_qos_cases = vec![
288+
Case {
289+
uid: 2,
290+
mode: 15,
291+
priority: 25,
292+
},
293+
Case {
294+
uid: 1,
295+
mode: 5,
296+
priority: 30,
297+
},
298+
Case {
299+
uid: 3,
300+
mode: 20,
301+
priority: 10,
302+
},
303+
];
304+
305+
let mut down_grade_case = &case;
306+
let mut swap_case_index_opt: Option<usize> = None;
307+
(high_qos_cases.iter().enumerate())
308+
.filter(|(i, swap_case)| {
309+
down_grade_case.uid == swap_case.uid
310+
&& (down_grade_case.mode < swap_case.mode
311+
|| down_grade_case.priority < swap_case.priority)
312+
})
313+
.for_each(|(i, swap_case)| {
314+
down_grade_case = swap_case;
315+
swap_case_index_opt = Some(i)
316+
});
317+
318+
println!("Downgrade case: {:?}", down_grade_case);
319+
println!("Swap case index: {:?}", swap_case_index_opt);
320+
}

lints/par_iter/ui/main.rs

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,13 @@ struct Pantheon {
2020
tasks: Vec<String>,
2121
}
2222

23+
#[derive(Debug, PartialEq)]
24+
struct Case {
25+
uid: u32,
26+
mode: u32,
27+
priority: u32,
28+
}
29+
2330
fn main() {}
2431

2532
// should parallelize
@@ -268,3 +275,46 @@ fn mut_var_declared_in_closure() {
268275
.collect();
269276
println!("{:?}", doubled_numbers);
270277
}
278+
279+
// no
280+
fn request_request_filter() {
281+
let case = Case {
282+
uid: 1,
283+
mode: 10,
284+
priority: 20,
285+
};
286+
287+
let high_qos_cases = vec![
288+
Case {
289+
uid: 2,
290+
mode: 15,
291+
priority: 25,
292+
},
293+
Case {
294+
uid: 1,
295+
mode: 5,
296+
priority: 30,
297+
},
298+
Case {
299+
uid: 3,
300+
mode: 20,
301+
priority: 10,
302+
},
303+
];
304+
305+
let mut down_grade_case = &case;
306+
let mut swap_case_index_opt: Option<usize> = None;
307+
(high_qos_cases.iter().enumerate())
308+
.filter(|(i, swap_case)| {
309+
down_grade_case.uid == swap_case.uid
310+
&& (down_grade_case.mode < swap_case.mode
311+
|| down_grade_case.priority < swap_case.priority)
312+
})
313+
.for_each(|(i, swap_case)| {
314+
down_grade_case = swap_case;
315+
swap_case_index_opt = Some(i)
316+
});
317+
318+
println!("Downgrade case: {:?}", down_grade_case);
319+
println!("Swap case index: {:?}", swap_case_index_opt);
320+
}

lints/par_iter/ui/main.stderr

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
error: found iterator that can be parallelized
2-
--> $DIR/main.rs:27:5
2+
--> $DIR/main.rs:34:5
33
|
44
LL | (0..100).into_iter().for_each(|x| println!("{:?}", x));
55
| ^^^^^^^^^^^^^^^^^^^^ help: try using a parallel iterator: `(0..100).into_par_iter()`
@@ -8,7 +8,7 @@ LL | (0..100).into_iter().for_each(|x| println!("{:?}", x));
88
= help: to override `-D warnings` add `#[allow(par_iter)]`
99

1010
error: found iterator that can be parallelized
11-
--> $DIR/main.rs:51:5
11+
--> $DIR/main.rs:58:5
1212
|
1313
LL | / (0..100)
1414
LL | | .into_iter()
@@ -21,37 +21,37 @@ LL + .into_par_iter()
2121
|
2222

2323
error: found iterator that can be parallelized
24-
--> $DIR/main.rs:86:5
24+
--> $DIR/main.rs:93:5
2525
|
2626
LL | list.into_iter().for_each(|x| println!("{:?}", x));
2727
| ^^^^^^^^^^^^^^^^ help: try using a parallel iterator: `list.into_par_iter()`
2828

2929
error: found iterator that can be parallelized
30-
--> $DIR/main.rs:102:5
30+
--> $DIR/main.rs:109:5
3131
|
3232
LL | (0..10).into_iter().for_each(|x| {
3333
| ^^^^^^^^^^^^^^^^^^^ help: try using a parallel iterator: `(0..10).into_par_iter()`
3434

3535
error: found iterator that can be parallelized
36-
--> $DIR/main.rs:185:5
36+
--> $DIR/main.rs:192:5
3737
|
3838
LL | data.iter()
3939
| ^^^^^^^^^^^ help: try using a parallel iterator: `data.par_iter()`
4040

4141
error: found iterator that can be parallelized
42-
--> $DIR/main.rs:212:5
42+
--> $DIR/main.rs:219:5
4343
|
4444
LL | numbers.iter().enumerate().for_each(|t| {
4545
| ^^^^^^^^^^^^^^ help: try using a parallel iterator: `numbers.par_iter()`
4646

4747
error: found iterator that can be parallelized
48-
--> $DIR/main.rs:253:30
48+
--> $DIR/main.rs:260:30
4949
|
5050
LL | let names: Vec<String> = people.iter().map(|p| p.name.clone()).collect();
5151
| ^^^^^^^^^^^^^ help: try using a parallel iterator: `people.par_iter()`
5252

5353
error: found iterator that can be parallelized
54-
--> $DIR/main.rs:261:37
54+
--> $DIR/main.rs:268:37
5555
|
5656
LL | let doubled_numbers: Vec<i32> = numbers
5757
| _____________________________________^

0 commit comments

Comments
 (0)