Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C64] Color support causes up2400 driver to crash. #33

Open
tschak909 opened this issue Sep 1, 2019 · 1 comment
Open

[C64] Color support causes up2400 driver to crash. #33

tschak909 opened this issue Sep 1, 2019 · 1 comment
Labels
c64 Commodore 64 help wanted Extra attention is needed

Comments

@tschak909
Copy link
Owner

When color support is enabled (with appropriate define in makefile) for color support, the up2400 driver fails and PLATOTERM crashes.

The swiftlink driver is
The color support requires an NMI trampoline to alter color ram, and I've in-lined it with the text output code, here:
https://github.com/tschak909/platoterm64/blob/master/src/c64/screen.c#L311

The existing NMI trampoline is here:
https://github.com/tschak909/platoterm64/blob/master/src/c64/nmi-trampoline.s#L1

and the user port 2400 driver for cc65 is here:
https://github.com/nanoflite/c64-up2400-cc65/blob/master/driver/c64-up2400.s

I suspect I may not be properly accounting for the NMI trampoline when flipping things in and out for color ram access.

-Thom

@tschak909 tschak909 added help wanted Extra attention is needed c64 Commodore 64 labels Sep 1, 2019
@rhalkyard
Copy link
Contributor

Just as a data point, I don't see any crashes when running with colour enabled, at least not on a fresh build of the master branch - text gets coloured as expected. Not sure if that's anything to do with my UP2400 issues in #37 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c64 Commodore 64 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants