Skip to content

Commit 63566d3

Browse files
authored
Merge pull request #1023 from brieuclehmann/test_relatedness
Add tests for genetic_relatedness
2 parents 1e66249 + 46b2e3f commit 63566d3

File tree

4 files changed

+321
-258
lines changed

4 files changed

+321
-258
lines changed

c/tskit/trees.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2762,17 +2762,21 @@ genetic_relatedness_summary_func(size_t state_dim, const double *state,
27622762
tsk_id_t i, j;
27632763
size_t k;
27642764
double sumx = 0;
2765-
double meanx;
2765+
double sumn = 0;
2766+
double meanx, ni, nj;
27662767

27672768
for (k = 0; k < state_dim; k++) {
27682769
sumx += x[k];
2770+
sumn += args.sample_set_sizes[k];
27692771
}
27702772

2771-
meanx = sumx / (double) state_dim;
2773+
meanx = sumx / sumn;
27722774
for (k = 0; k < result_dim; k++) {
27732775
i = args.set_indexes[2 * k];
27742776
j = args.set_indexes[2 * k + 1];
2775-
result[k] = (x[i] - meanx) * (x[j] - meanx) / 2;
2777+
ni = args.sample_set_sizes[i];
2778+
nj = args.sample_set_sizes[j];
2779+
result[k] = (x[i] - ni * meanx) * (x[j] - nj * meanx) / 2;
27762780
}
27772781
return 0;
27782782
}

python/tests/test_covariance.py

Lines changed: 0 additions & 253 deletions
This file was deleted.

0 commit comments

Comments
 (0)