stack-buffer-overflow inside detect_file_format

[kcwu]

lnav version
v0.12.4 is the latest

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Build lnav with asan CXXFLAGS='-g -O0 -fsanitize=address'
2. echo 'KLUv/QRYbQAAMB+LCBEwAAEAAtADLa8636k=' | base64 -d | zstd -d | ./lnav.asan -n

=================================================================
==1373390==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f529010a4a0 at pc 0x55e4e040d8b7 bp 0x7f5293bfd2d0 sp 0x7f5293bfca98
READ of size 4097 at 0x7f529010a4a0 thread T5
    #0 0x55e4e040d8b6 in strlen (/btrfs2/fuzz/targets/lnav/run/lnav.asan+0x3268b6) (BuildId: 7f0fe21f72d9d7b737a6d80eb83a31a57b8f08d7)
    #1 0x55e4e0557114 in std::char_traits<char>::length(char const*) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/char_traits.h:391:9
    #2 0x55e4e0529c55 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>::basic_string<std::allocator<char>>(char const*, std::allocator<char> const&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/basic_string.h:653:30
    #3 0x55e4e0afe2e8 in line_buffer::gz_indexed::open(int, lnav::gzip::header&) /btrfs2/fuzz/targets/lnav/lnav/src/line_buffer.cc:237:36
    #4 0x55e4e0b01f8b in line_buffer::set_fd(auto_fd&) /btrfs2/fuzz/targets/lnav/lnav/src/line_buffer.cc:461:53
    #5 0x55e4e0a4c832 in detect_file_format(std::filesystem::__cxx11::path const&) /btrfs2/fuzz/targets/lnav/lnav/src/file_format.cc:101:20
    #6 0x55e4e0a135c7 in file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0::operator()() /btrfs2/fuzz/targets/lnav/lnav/src/file_collection.cc:424:27
    #7 0x55e4e0a12e2f in file_collection std::__invoke_impl<file_collection, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::__invoke_other, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61:14
    #8 0x55e4e0a12ddf in std::__invoke_result<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>::type std::__invoke<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:96:14
    #9 0x55e4e0a12daf in file_collection std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>::_M_invoke<0ul>(std::_Index_tuple<0ul>) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_thread.h:301:13
    #10 0x55e4e0a12d6f in std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>::operator()() /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_thread.h:308:11
    #11 0x55e4e0a12a69 in std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::operator()() const /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/future:1416:27
    #12 0x55e4e0a1286f in std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter> std::__invoke_impl<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>&>(std::__invoke_other, std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:61:14
    #13 0x55e4e0a127a7 in std::enable_if<is_invocable_r_v<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter>, std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>&>, std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter>>::type std::__invoke_r<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter>, std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>&>(std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:114:9
    #14 0x55e4e0a125cf in std::_Function_handler<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> (), std::__future_base::_Task_setter<std::unique_ptr<std::__future_base::_Result<file_collection>, std::__future_base::_Result_base::_Deleter>, std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>>::_M_invoke(std::_Any_data const&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:290:9
    #15 0x55e4e064cb8a in std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>::operator()() const /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_function.h:591:9
    #16 0x55e4e064c497 in std::__future_base::_State_baseV2::_M_do_set(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/future:596:27
    #17 0x55e4e064cb15 in void std::__invoke_impl<void, void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::__invoke_memfun_deref, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:74:14
    #18 0x55e4e064c9dc in std::__invoke_result<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>::type std::__invoke<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:96:14
    #19 0x55e4e064c9a4 in void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&)::'lambda'()::operator()() const /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/mutex:909:4
    #20 0x55e4e064c8d4 in std::once_flag::_Prepare_execution::_Prepare_execution<void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&)::'lambda'()>(void (std::__future_base::_State_baseV2::*&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*))::'lambda'()::operator()() const /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/mutex:845:21
    #21 0x55e4e064c83b in std::once_flag::_Prepare_execution::_Prepare_execution<void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&)::'lambda'()>(void (std::__future_base::_State_baseV2::*&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*))::'lambda'()::__invoke() /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/mutex:845:16
    #22 0x7f529a1bb086 in __pthread_once_slow nptl/pthread_once.c:116:7
    #23 0x7f529a1bb0f8 in __pthread_once nptl/pthread_once.c:143:12
    #24 0x55e4e051fa66 in __gthread_once(int*, void (*)()) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/x86_64-linux-gnu/c++/14/bits/gthr-default.h:713:12
    #25 0x55e4e064c297 in void std::call_once<void (std::__future_base::_State_baseV2::*)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*>(std::once_flag&, void (std::__future_base::_State_baseV2::*&&)(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*, bool*), std::__future_base::_State_baseV2*&&, std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>*&&, bool*&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/mutex:916:21
    #26 0x55e4e064b89a in std::__future_base::_State_baseV2::_M_set_result(std::function<std::unique_ptr<std::__future_base::_Result_base, std::__future_base::_Result_base::_Deleter> ()>, bool) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/future:435:2
    #27 0x55e4e0a11e29 in std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::_M_run() /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/future:1781:6
    #28 0x55e4e0a18940 in void std::__invoke_impl<void, void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*>(std::__invoke_memfun_deref, void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*&&)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:74:14
    #29 0x55e4e0a1882c in std::__invoke_result<void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*>::type std::__invoke<void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*>(void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*&&)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/invoke.h:96:14
    #30 0x55e4e0a18801 in void std::thread::_Invoker<std::tuple<void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*>>::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_thread.h:301:13
    #31 0x55e4e0a187c4 in std::thread::_Invoker<std::tuple<void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*>>::operator()() /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_thread.h:308:11
    #32 0x55e4e0a18608 in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::*)(), std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*>>>::_M_run() /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/std_thread.h:253:13
    #33 0x7f529a4e0f23  (/lib/x86_64-linux-gnu/libstdc++.so.6+0xe0f23) (BuildId: 52c8d30d5a7354e6c32cbf0c2fbd39646b6c8075)
    #34 0x55e4e049314a in asan_thread_start(void*) asan_interceptors.cpp.o
    #35 0x7f529a1b6102 in start_thread nptl/pthread_create.c:447:8
    #36 0x7f529a2347b7 in __GI___clone3 misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:78

Address 0x7f529010a4a0 is located in stack of thread T5 at offset 5280 in frame
    #0 0x55e4e0afd92f in line_buffer::gz_indexed::open(int, lnav::gzip::header&) /btrfs2/fuzz/targets/lnav/lnav/src/line_buffer.cc:190

  This frame has 9 object(s):
    [32, 1056) 'name' (line 195)
    [1184, 5280) 'comment' (line 196)
    [5408, 5488) 'gz_hd' (line 201) <== Memory access at offset 5280 partially underflows this variable
    [5520, 13712) 'inbuf' (line 208) <== Memory access at offset 5280 partially underflows this variable
    [13968, 22160) 'outbuf' (line 209)
    [22416, 22448) 'ref.tmp' (line 236)
    [22480, 22481) 'ref.tmp36' (line 236)
    [22496, 22528) 'ref.tmp38' (line 237)
    [22560, 22561) 'ref.tmp40' (line 237)
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
      (longjmp and C++ exceptions *are* supported)
Thread T5 created by T0 here:
    #0 0x55e4e047ad05 in pthread_create (/btrfs2/fuzz/targets/lnav/run/lnav.asan+0x393d05) (BuildId: 7f0fe21f72d9d7b737a6d80eb83a31a57b8f08d7)
    #1 0x7f529a4e0ff8 in std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State>>, void (*)()) (/lib/x86_64-linux-gnu/libstdc++.so.6+0xe0ff8) (BuildId: 52c8d30d5a7354e6c32cbf0c2fbd39646b6c8075)
    #2 0x55e4e0a11b51 in std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>::_Async_state_impl<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/future:1763:16
    #3 0x55e4e0a1199c in void std::_Construct<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/stl_construct.h:119:25
    #4 0x55e4e0a112a3 in void std::allocator_traits<std::allocator<void>>::construct<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::allocator<void>&, std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/alloc_traits.h:657:4
    #5 0x55e4e0a112a3 in std::_Sp_counted_ptr_inplace<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>, std::allocator<void>, (__gnu_cxx::_Lock_policy)2>::_Sp_counted_ptr_inplace<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::allocator<void>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:607:4
    #6 0x55e4e0a10ee9 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>, std::allocator<void>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>*&, std::_Sp_alloc_shared_tag<std::allocator<void>>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:970:6
    #7 0x55e4e0a10d1b in std::__shared_ptr<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<void>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::_Sp_alloc_shared_tag<std::allocator<void>>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr_base.h:1713:14
    #8 0x55e4e0a10c9e in std::shared_ptr<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>>::shared_ptr<std::allocator<void>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::_Sp_alloc_shared_tag<std::allocator<void>>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:463:4
    #9 0x55e4e0a10a04 in std::shared_ptr<std::enable_if<!is_array<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>>::value, std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>>::type> std::make_shared<std::__future_base::_Async_state_impl<std::thread::_Invoker<std::tuple<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>>, file_collection>, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/bits/shared_ptr.h:1007:14
    #10 0x55e4e0a0bd51 in std::future<std::__invoke_result<std::decay<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>::type>::type> std::async<file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0>(std::launch, file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool)::$_0&&) /usr/lib/gcc/x86_64-linux-gnu/14/../../../../include/c++/14/future:1812:18
    #11 0x55e4e0a0b1b6 in file_collection::watch_logfile(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool) /btrfs2/fuzz/targets/lnav/lnav/src/file_collection.cc:609:16
    #12 0x55e4e0a0e5b0 in file_collection::expand_filename(lnav::futures::future_queue<file_collection>&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, logfile_open_options&, bool) /btrfs2/fuzz/targets/lnav/lnav/src/file_collection.cc:761:35
    #13 0x55e4e0a0f162 in file_collection::rescan_files(bool) /btrfs2/fuzz/targets/lnav/lnav/src/file_collection.cc:811:19
    #14 0x55e4e070856b in rescan_files(bool) /btrfs2/fuzz/targets/lnav/lnav/src/lnav.indexing.cc:511:45
    #15 0x55e4e04f2f27 in main /btrfs2/fuzz/targets/lnav/lnav/src/lnav.cc:3750:17
    #16 0x7f529a14dd67 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

SUMMARY: AddressSanitizer: stack-buffer-overflow (/btrfs2/fuzz/targets/lnav/run/lnav.asan+0x3268b6) (BuildId: 7f0fe21f72d9d7b737a6d80eb83a31a57b8f08d7) in strlen
Shadow bytes around the buggy address:
  0x7f529010a200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a300: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a400: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x7f529010a480: 00 00 00 00[f2]f2 f2 f2 f2 f2 f2 f2 f2 f2 f2 f2
  0x7f529010a500: f2 f2 f2 f2 00 00 00 00 00 00 00 00 00 00 f2 f2
  0x7f529010a580: f2 f2 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x7f529010a700: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==1373390==ABORTING

found by afl++

[tstack]

I think this is fixed now.