You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Opening VSCode window on a .gts in TS Plugin mode might not have diagnostics until changed/kicked
Debug Extension (TS Plugin Only)
Open src/glimmer.gts
Close all other windows. Start over; launch debug session, glimmer.gts will open, and depending on race conditions you might not get diagnostics until/unless you edit the file or click some tab in VSCode that for "reasons" will trigger diagnostics.
Root cause: our use of createAsyncLanguageServicePlugin to initialize our TS Plugin (which we need so that we can dynamically await import('@glint/core') ESM module from our CJS code) introduces some async that causes the TS Plugin to finish initializing after the first geterr (request diagnostics) command is sent to tsserver.
Other Volar tooling
Vue - unable to repro
MDX - unable to repro
That said if I introduce a 2s timeout in the middle of MDX's async setup fn, it yields the same behavior as Glint; MDX plugin won't finish initializing until after first geterr within tsserver.
I'm not sure why Glint is so comparably slow, but sounds like some perf work is needed and/or we should see if there's a way to trigger a re-diagnostics calculation after TS Plugins finish loaded.
The text was updated successfully, but these errors were encountered:
Opening VSCode window on a .gts in TS Plugin mode might not have diagnostics until changed/kicked
src/glimmer.gts
Root cause: our use of
createAsyncLanguageServicePlugin
to initialize our TS Plugin (which we need so that we can dynamicallyawait import('@glint/core')
ESM module from our CJS code) introduces some async that causes the TS Plugin to finish initializing after the firstgeterr
(request diagnostics) command is sent to tsserver.Other Volar tooling
geterr
within tsserver.I'm not sure why Glint is so comparably slow, but sounds like some perf work is needed and/or we should see if there's a way to trigger a re-diagnostics calculation after TS Plugins finish loaded.
The text was updated successfully, but these errors were encountered: