Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate build declaration fails for sandbox #161

Open
huntc opened this issue Jun 30, 2016 · 1 comment
Open

Release candidate build declaration fails for sandbox #161

huntc opened this issue Jun 30, 2016 · 1 comment

Comments

@huntc
Copy link
Contributor

huntc commented Jun 30, 2016

sandbox run 1.1.8-rc.1 fails given that the - is interpreted as an option

@markusjura
Copy link
Contributor

So far the sbt-conductr parser expects that the conductr version consists of only digits and dots: https://github.com/typesafehub/sbt-conductr/blob/master/src/main/scala/com/lightbend/conductr/sbt/ConductRPlugin.scala#L656

This is reason why it fails. We can relax the expected format. We need to be careful though to not generalize too much because otherwise the parser can't distinguish anymore between a conductr version and a option. This would mean that auto completion will not work anymore, because the conductr version can be put to any position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants