Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: merge MathUtils and MathHelper classes #221

Open
ghost opened this issue Feb 7, 2018 · 1 comment
Open

Suggestion: merge MathUtils and MathHelper classes #221

ghost opened this issue Feb 7, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented Feb 7, 2018

MathUtils and MathHelper classes partially duplicate each other.
I was trying to use MathUtils and did not find particular method (RadiansToDegrees), so ended up implementing it on my own, and later found that method already existed in MathHelper.

Is there anything that prevents combining them in one class?

@ivan-mogilko ivan-mogilko changed the title Suggestion: merge MathUtil and MathHelper classes Suggestion: merge MathUtils and MathHelper classes Feb 7, 2018
@tzachshabtay
Copy link
Owner

MathHelper is part of OpenTK. It's currently copied to AGS.API for technical reasons (like all other classes in the OpenTK folder). It's temporary- OpenTK are planning to split the library into modules, one of them will be OpenTK.Math (see here: opentk/opentk#360). Once that happens I'll be able to use OpenTK.Math and delete MathHelper and the rest of the classes from the API.

Until that happens, I don't want to touch anything in that class, as it will make things harder later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant