Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing tweakers.net cookie dialog handling #27014

Closed
wants to merge 1 commit into from

Conversation

kaoneko
Copy link

@kaoneko kaoneko commented Jan 29, 2025

URL(s) where the issue occurs

https://tweakers.net/

Describe the issue

The existing rule has no effect (anymore), the cookie consent dialog is not dismissed. I have updated the rule to target the proper CSS selectors.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Updated CSS selectors.
@kaoneko
Copy link
Author

kaoneko commented Jan 30, 2025

Looking at this a bit longer, I see the real problem is the outdated rules for myprivacy.dpgmedia.nl in annoyances-cookies.txt, which fail to handle the DPG Media cookie wall correctly because of the same outdated CSS selectors and maybe conflicting rules too.

When visiting a DPG Media site like tweakers.net for the first time, one gets redirected to e.g. https://myprivacy.dpgmedia.nl/consent?callbackUrl=https%3A%2F%2Fwww.tweakers.net%2F&siteKey=ehnsj7n39x9wm5sy which handles the privacy choices for all DPG Media sites. When the user succesfully sets their preferences there once, visiting any DPG Media site doesn't show a cookie consent dialog anymore. However, currently the annoyances-cookies.txt doesn't handle this correctly, resulting in a cookie consent dialog on each individual DPG Media host (tweakers.net, nu.nl, reclamefolder.nl etc.)

While this pull request is an improvement for now, it doesn't address the real problem. If the problem can be addressed on the level of dpgmedia.nl, we don't need a separate rule for tweakers.net anymore. So far I got this:

myprivacy.dpgmedia.nl##+js(trusted-click-element, '#pg-host-shadow-root >>> button#pg-configure-btn, #pg-host-shadow-root >>> #purpose-row-SOCIAL_MEDIA input[type="checkbox"], #pg-host-shadow-root >>> button#pg-save-preferences-btn')

Which is a corrected version of one of the existing dpgmedia.nl rules (which allows embedded social media). It handles all DPG Media sites at once for the ones I tested (tweakers.net, nu.nl, reclamefolder.nl) when I disable the uBlock Filters - Cookie notices list in UBO (which has one or more conflicting rules).

This needs more looking into and shouldn't block the merging of this pull request, but may in the end make this pull request obsolete, if I or anyone has the time to really look into properly handling all DPG Media sites. Also, I'm very new to all of this.

@kaoneko
Copy link
Author

kaoneko commented Jan 30, 2025

I'm on it, expect a new pull request soon; closing this one.

@kaoneko kaoneko closed this Jan 30, 2025
@kaoneko kaoneko deleted the patch-1 branch January 30, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant