Skip to content

[WIP] Replace Comfortable Mexican Sofa with Comfortable Media Surfer Gem; address #737 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jefferya wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[WIP] Replace Comfortable Mexican Sofa with Comfortable Media Surfer Gem; address #737 #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
af9a23a
Update from Rails 7.2.x to 8.0.x; address #880
jefferya Nov 4, 2025
ca7555f
Bump rails from 8.0 to 8.1; address #880
jefferya Nov 6, 2025
6744daf
Update comfortable-mexican-sofa to ComfortableMediaSurfer; addresss #737
jefferya Nov 6, 2025
31d6a5d
Remove default colume serializer due to https://github.com/shakacode/…
jefferya Nov 6, 2025
29b0556
Readme updates.
jefferya Nov 6, 2025
1b68816
Comfortable Media Surf requires a DB Migration to fix tests
jefferya Nov 7, 2025
aecfd4b
Include DB schema change required by robocop.
jefferya Nov 7, 2025
12d6542
Infrastructure to compile CMS Rails Engine assets.
jefferya Dec 4, 2025
1074f10
Update bin/setup to include comfy:compile_assets
jefferya Dec 4, 2025
5321ac9
Update comfortable_media_surf 3.1.4 to 3.1.5 and Rails 8.1.1 to 8.1.2
jefferya Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ jobs:
ruby-version: .ruby-version
bundler-cache: true

- name: Compile CMS Engine assets
run: bundle exec rails comfy:compile_assets
env:
RAILS_ENV: test

Comment on lines +49 to +53
Copy link
Contributor Author

@jefferya jefferya Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to install and build the CMS Engine's javascript and CSS. The new Gem doesn't include the vendor javascript libraries and bundles.

- name: Read Node version from .tool-versions
id: node_version
run: |
Expand All @@ -69,6 +74,11 @@ jobs:
- name: Install Node modules
run: yarn install

- name: Test - precompile Rails assets
run: bundle exec rails assets:precompile
env:
RAILS_ENV: test

Comment on lines +77 to +81
Copy link
Contributor Author

@jefferya jefferya Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test to see if assets:precompile works.

- name: Run tests
env:
RAILS_ENV: test
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby ">= 3.1.4", "< 3.5"

gem "rails", "~> 7.2.2"
gem "rails", "~> 8.1.1"

gem "mysql2", "~> 0.5.6"
# Use Puma as the app server
Expand Down Expand Up @@ -33,7 +33,7 @@ gem "jbuilder", "~> 2.14"
# Use ActiveStorage variant
gem "image_processing", "~> 1.14"

gem "comfortable_mexican_sofa", github: "restarone/comfortable-mexican-sofa", tag: "3.5"
gem "comfortable_media_surfer", "~> 3.1.0"

gem "htmlentities"
# Reduces boot times through caching; required in config/boot.rb
Expand Down
Loading
Loading