Skip to content

Commit 19d5b2a

Browse files
committed
updates per code review by @jpwhite4
1 parent 7dee7e0 commit 19d5b2a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.circleci/config.yml

+6
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@ jobs:
6767
- run:
6868
name: Build XDMoD RPM
6969
command: docker exec -w /root/xdmod xdmod /root/bin/buildrpm xdmod
70+
71+
# This when condition will only trigger if the build is being run by:
72+
# - a scheduled pipline ( cron job ) called "xdmod-time-trigger"
73+
# OR
74+
# - if the build has the "schedule-name" parameter set to "xdmod-time-trigger"
75+
# This is so that we can manually trigger code coverage generation for testing purposes.
7076
- when:
7177
condition:
7278
or:

tools/dev/code_coverage/codeCoverageSetup.sh

-6
Original file line numberDiff line numberDiff line change
@@ -500,13 +500,7 @@ echo ${arg_r}
500500
echo
501501
echo $PROCESS_FILE_INSTALL_PATH
502502

503-
#~/bin/services restart
504-
505503
### Create / Update privs for the directory that will contain the code coverage reports.
506504
mkdir "${arg_c}"
507505
chmod 777 "${arg_c}"
508506
chown root:apache "${arg_c}"
509-
510-
### Make sure to restart the services so that these changes take effect.x
511-
#~/bin/services stop
512-
#~/bin/services start

0 commit comments

Comments
 (0)