Upgrade all d3 depencencies (#1466)

* upgrade all d3 dependencies

* update yarn.lock

* add transformIgnorePatterns

* add regenerator-runtime

* fix long dash in unit test

* fix contour

* fix sankey diagram

Author: kenns29

packages/react-vis/jest.config.js

@@ -7,5 +7,7 @@ module.exports = {
   },
   setupFilesAfterEnv: ['./jest.setup.js'],
   snapshotSerializers: ['enzyme-to-json/serializer'],
-  transformIgnorePatterns: ['/node_modules/(?!d3-color)']
+  transformIgnorePatterns: [
+    '/node_modules/(?!(d3-color|d3-scale|d3-interpolate|d3-hierarchy|d3-format|d3-shape|d3-array|d3-contour|d3-path|internmap|d3-time|d3-geo))'
+  ]
 };

packages/react-vis/jest.setup.js

@@ -1,4 +1,5 @@
 /*eslint-env node*/
+import 'regenerator-runtime/runtime';
 import jsdom from 'jsdom';
 import Enzyme from 'enzyme';
 import Adapter from 'enzyme-adapter-react-16';

packages/react-vis/package.json

@@ -33,19 +33,19 @@
     "prettier": "prettier --write $(git ls-files | grep '.js$')"
   },
   "dependencies": {
-    "d3-array": "^1.2.0",
-    "d3-collection": "^1.0.3",
+    "d3-array": "^3.2.1",
+    "d3-collection": "^1.0.7",
     "d3-color": "^3.1.0",
-    "d3-contour": "^1.1.0",
-    "d3-format": "^1.2.0",
-    "d3-geo": "^1.6.4",
+    "d3-contour": "^4.0.0",
+    "d3-format": "^3.1.0",
+    "d3-geo": "^3.1.0",
     "d3-hexbin": "^0.2.2",
-    "d3-hierarchy": "^1.1.4",
-    "d3-interpolate": "^1.1.4",
-    "d3-sankey": "^0.7.1",
-    "d3-scale": "^1.0.5",
-    "d3-shape": "^1.1.0",
-    "d3-voronoi": "^1.1.2",
+    "d3-hierarchy": "^3.1.2",
+    "d3-interpolate": "^3.0.1",
+    "d3-sankey": "^0.12.3",
+    "d3-scale": "^4.0.2",
+    "d3-shape": "^3.2.0",
+    "d3-voronoi": "^1.1.4",
     "deep-equal": "^1.0.1",
     "global": "^4.3.1",
     "prop-types": "^15.5.8",
@@ -81,6 +81,7 @@
     "react-dom": "^16.0.0",
     "react-test-renderer": "^16.13.1",
     "react-vis-showcase": "^0.1.0",
+    "regenerator-runtime": "^0.13.11",
     "stylelint": "^7.7.1",
     "stylelint-config-standard": "^15.0.1",
     "uglify-js": "^2.8.22"

packages/react-vis/src/sankey/index.js

@@ -60,6 +60,17 @@ function Sankey(props) {
     style,
     width
   } = props;
+  // d3-sankey sankeyInstance no longer accepts empty nodes array, return empty XYPlot by default
+  if (nodes.length === 0) {
+    return (
+      <XYPlot
+        {...props}
+        yType="literal"
+        className={getCombinedClassName('rv-sankey', className)}
+      />
+    );
+  }
+
   const nodesCopy = [...new Array(nodes.length)].map((e, i) => ({
     ...nodes[i]
   }));

packages/react-vis/tests/components/arc-series.test.js

@@ -13,7 +13,7 @@ describe('ArcSeries', () => {
         <ArcSeriesExample />
       </svg>
     );
-    expect($.text()).toBe('UPDATE-4-2024-4-2024');
+    expect($.text()).toBe('UPDATE−4−2024−4−2024');
     // multiplied by two to account for shadow listeners
     expect($.find('.rv-xy-plot__series--arc').length).toBe(4);
     expect($.find('.rv-xy-plot__series--arc path').length).toBe(2 * 8);

packages/react-vis/tests/components/bar-series.test.js

@@ -100,7 +100,7 @@ describe('BarSeries', () => {
 
   test('Showcase Example - DifferenceChart', () => {
     const $ = mount(<DifferenceChart />);
-    expect($.text()).toBe('TOGGLE TO CANVAS02468101214-4-20246810');
+    expect($.text()).toBe('TOGGLE TO CANVAS02468101214−4−20246810');
     expect($.find('.rv-xy-plot__series--bar rect').length).toBe(15);
     expect($.find('.rv-xy-plot__series').length).toBe(1);
 

packages/react-vis/tests/components/circular-grid-lines.test.js

@@ -9,7 +9,7 @@ describe('CircularGridLines', () => {
 
   test('Showcase Example - FauxRadialScatterplot', () => {
     const $ = mount(<FauxRadialScatterplot />);
-    expect($.text()).toBe('-3-2-10123-3-2-10123');
+    expect($.text()).toBe('−3−2−10123−3−2−10123');
     expect($.find('.rv-xy-plot__circular-grid-lines__line').length).toBe(7);
   });
 });

packages/react-vis/tests/components/contour-series.test.js

@@ -11,6 +11,6 @@ describe('ContourSeries', () => {
     const $ = mount(<ContourSeriesExample />);
     expect($.text()).toBe('4045505560657075808590951002345678UPDATE');
     expect($.find('.rv-xy-plot__series--contour').length).toBe(1);
-    expect($.find('.rv-xy-plot__series--contour-line').length).toBe(28);
+    expect($.find('.rv-xy-plot__series--contour-line').length).toBe(17);
   });
 });

packages/react-vis/tests/components/decorative-axis.test.js

@@ -20,7 +20,7 @@ describe('DecorativeAxis', () => {
   test('Showcase Example - DecorativeAxisCrissCross', () => {
     const $ = mount(<DecorativeAxisCrissCross />);
     expect($.text()).toBe(
-      '-101.01223344556677889100¡1000!¡990!¡980!¡970!¡960!¡950!¡940!¡930!¡920!¡910!¡900!'
+      '−101.01223344556677889100¡1000!¡990!¡980!¡970!¡960!¡950!¡940!¡930!¡920!¡910!¡900!'
     );
     expect($.find('.rv-xy-manipulable-axis').length).toBe(2);
     expect($.find('.rv-xy-plot__axis__tick__line').length).toBe(22);

packages/react-vis/tests/components/highlight.test.js

@@ -58,7 +58,7 @@ describe('Highlight', () => {
   test('ZoomableChartExample', () => {
     const $ = mount(<ZoomableChartExample />);
     const initialText =
-      '-5051015200102030405060708090Reset ZoomLast Draw AreaN/A';
+      '−5051015200102030405060708090Reset ZoomLast Draw AreaN/A';
     expect($.text()).toBe(initialText);
 
     // brush in a drag area
@@ -76,7 +76,7 @@ describe('Highlight', () => {
       nativeEvent: {offsetX: 200, offsetY: 200}
     });
     expect($.text()).toBe(
-      '-5051015200102030405060708090Reset ZoomLast Draw AreaTop: 11.083578425950623Right: 34.98Bottom: -0.5863163548405383Left: 13.2'
+      '−5051015200102030405060708090Reset ZoomLast Draw AreaTop: 11.083578425950623Right: 34.98Bottom: -0.5863163548405383Left: 13.2'
     );
   });