Skip to content

Commit d0f0632

Browse files
authored
interfaces returns RadarInterfaces (commaai#33444)
* interfaces returns radarinterface * bump * bump * bump old-commit-hash: f94ef10
1 parent 1e92af9 commit d0f0632

File tree

6 files changed

+7
-9
lines changed

6 files changed

+7
-9
lines changed

selfdrive/car/tests/test_car_interfaces.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class TestCarInterfaces:
3535
phases=(Phase.reuse, Phase.generate, Phase.shrink))
3636
@given(data=st.data())
3737
def test_car_interfaces(self, car_name, data):
38-
CarInterface, CarController, CarState = interfaces[car_name]
38+
CarInterface, CarController, CarState, RadarInterface = interfaces[car_name]
3939

4040
args = get_fuzzy_car_interface_args(data.draw)
4141

selfdrive/car/tests/test_models.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import copy
33
import dataclasses
44
import os
5-
import importlib
65
import pytest
76
import random
87
import unittest # noqa: TID251
@@ -173,7 +172,7 @@ def setUpClass(cls):
173172

174173
cls.can_msgs = sorted(can_msgs, key=lambda msg: msg.logMonoTime)
175174

176-
cls.CarInterface, cls.CarController, cls.CarState = interfaces[cls.platform]
175+
cls.CarInterface, cls.CarController, cls.CarState, cls.RadarInterface = interfaces[cls.platform]
177176
cls.CP = cls.CarInterface.get_params(cls.platform, cls.fingerprint, car_fw, experimental_long, docs=False)
178177
assert cls.CP
179178
assert cls.CP.carFingerprint == cls.platform
@@ -234,8 +233,7 @@ def test_car_interface(self):
234233
self.assertEqual(can_invalid_cnt, 0)
235234

236235
def test_radar_interface(self):
237-
RadarInterface = importlib.import_module(f'opendbc.car.{self.CP.carName}.radar_interface').RadarInterface
238-
RI = RadarInterface(self.CP)
236+
RI = self.RadarInterface(self.CP)
239237
assert RI
240238

241239
# Since OBD port is multiplexed to bus 1 (commonly radar bus) while fingerprinting,

selfdrive/controls/lib/tests/test_latcontrol.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class TestLatControl:
1818

1919
@parameterized.expand([(HONDA.HONDA_CIVIC, LatControlPID), (TOYOTA.TOYOTA_RAV4, LatControlTorque), (NISSAN.NISSAN_LEAF, LatControlAngle)])
2020
def test_saturation(self, car_name, controller):
21-
CarInterface, CarController, CarState = interfaces[car_name]
21+
CarInterface, CarController, CarState, RadarInterface = interfaces[car_name]
2222
CP = CarInterface.get_non_essential_params(car_name)
2323
CI = CarInterface(CP, CarController, CarState)
2424
CP = convert_to_capnp(CP)

selfdrive/controls/tests/test_state_machine.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def make_event(event_types):
2828
class TestStateMachine:
2929

3030
def setup_method(self):
31-
CarInterface, CarController, CarState = interfaces[MOCK.MOCK]
31+
CarInterface, CarController, CarState, RadarInterface = interfaces[MOCK.MOCK]
3232
CP = CarInterface.get_non_essential_params(MOCK.MOCK)
3333
CI = CarInterface(CP, CarController, CarState)
3434

selfdrive/test/process_replay/process_replay.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ def card_fingerprint_callback(rc, pm, msgs, fingerprint):
343343
def get_car_params_callback(rc, pm, msgs, fingerprint):
344344
params = Params()
345345
if fingerprint:
346-
CarInterface, _, _ = interfaces[fingerprint]
346+
CarInterface, _, _, _ = interfaces[fingerprint]
347347
CP = CarInterface.get_non_essential_params(fingerprint)
348348
else:
349349
can = DummySocket()

0 commit comments

Comments
 (0)