Course Issues

[alexanderson1993]

Example comment

title: Generics
issue: description of issue.

I'll "hide" the comment when it's fixed.

[AlbertVilaCalvo]

title: Introduction, Philosophy, and Tips - https://platform.ui.dev/courses/1207737/lectures/26967124
issue: video says that you are using Node 14, but text says Node v12.18.3

[AlbertVilaCalvo]

Also on the same lesson it says "We're preparing a course that will cover TypeScript in React in depth"

I guess you can change this given that the course is out now

[AlbertVilaCalvo]

Minor thing on the Quiz for Modifiers - https://platform.ui.dev/courses/1207737/lectures/26978345
Last question of the quiz says:

class Fruit {
  constructor(private _name:string) {}
  get name() {
    return this.name;
  }
}

I believe it should be _name:

class Fruit {
  constructor(private _name:string) {}
  get name() {
    return this._name;
  }
}

[AlbertVilaCalvo]

Repeated answer in Quiz for Conditional Types - https://platform.ui.dev/courses/1207737/lectures/27005661

On the question "What is the type of "output" in this example?"

The repeated answer is "string | { name?: string }" (appears twice)

[AlbertVilaCalvo]

Minor typo in "(Bonus) Typing an NPM module that has no types" - https://platform.ui.dev/courses/1207737/lectures/27006992

awy -> way

[alexanderson1993]

Thanks for all of this feedback. It's tremendously helpful!

[AlbertVilaCalvo]

Thanks ;)

Another thing. On the 'Generics' lesson - https://platform.ui.dev/courses/1207737/lectures/27005262

You have this code:

class Fruit {
  isFruit:true;
  constructor(public name:string) {}
}
class Apple extends Fruit {
  type:"Apple",
  constructor() {
    super("Apple")
  }
}
class Banana extends Fruit {
  type:"Banana",
  constructor() {
    super("Banana")
  }
}

I believe it should be more like:

class Fruit {
  isFruit = true;
  constructor(public name:string) {}
}
class Apple extends Fruit {
  type = "Apple";
  constructor() {
    super("Apple")
  }
}
class Banana extends Fruit {
  type = "Banana";
  constructor() {
    super("Banana")
  }
}

Note that things like this happen more than once on this lesson, eg:

class Vegetable {
  isFruit: false;
  constructor(public name: string) {}
}

[alexanderson1993]

That's a good catch. With certain TypeScript configurations, it would work just fine, but what you suggest definitely makes more sense.

[AlbertVilaCalvo]

In 'Module Resolution' - https://platform.ui.dev/courses/1207737/lectures/27007352

The text says "It can be helpful to this about this in terms of websites.", which is wrong.

The video says "It can be really helpful to think about this in terms of websites"

[AlbertVilaCalvo]

That's a good catch. With certain TypeScript configurations, it would work just fine, but what you suggest definitely makes more sense.

Good to know. To be honest I wasn't 100% sure about this, so I didn't report it at that time.

[AlbertVilaCalvo]

In '(Bonus) Configuring for Webpack Development', video sets target to es2019 but text says es2015.

And in '(Bonus) Configuring for Modern Web Development', video sets target es2020 but text says es2015.

[AlbertVilaCalvo]

In '(Bonus) Configuring for Webpack Development', video sets target to es2019 but text says es2015.

And in '(Bonus) Configuring for Modern Web Development', video sets target es2020 but text says es2015.

Something similar happens in '(Bonus) Configuring for Node Development' too

[AlbertVilaCalvo]

May I ask you what VSCode extension do you use to automatically evaluate the JS statements and see the results inline on the editor (eg for the console.log output)? Thanks ;)

[alexanderson1993]

May I ask you what VSCode extension do you use to automatically evaluate the JS statements and see the results inline on the editor (eg for the console.log output)? Thanks ;)

I'm using Quokka. https://quokkajs.com/docs/index.html

[CBedzz]

title: codesandbox type annotations practice has no "unknowns" or red squiggles
issue: in the basic type checking section, the type annotations practice codesandbox has nothing to correct. There are no unknown types or other ts warnings or errors to correct in annotations.ts.

the file linked from the lesson is: https://codesandbox.io/s/practice-type-annotations-m32lj?file=/src/annotations.ts

EDIT: I'm having the same issue with the interfaces practice in the special typescript types section. The CodeSandbox that is linked in the practice is already solved and has no ts errors or warnings.