Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update varyiteration variables to use LHS instead of RNG #3587

Open
ym1906 opened this issue Mar 13, 2025 · 2 comments
Open

Update varyiteration variables to use LHS instead of RNG #3587

ym1906 opened this issue Mar 13, 2025 · 2 comments
Assignees
Labels
Convergence Solver or convergence-related problems New feature Introduction of a new model / feature

Comments

@ym1906
Copy link
Collaborator

ym1906 commented Mar 13, 2025

I was looking at vary_iteration variables and at the moment it is done in a very rudimentary way, just randomly sampling for each calculation.

We could instead implement LHS sampling for a more efficient and comprehensive sample scheme.

@ym1906 ym1906 added Convergence Solver or convergence-related problems New feature Introduction of a new model / feature labels Mar 13, 2025
@timothy-nunn
Copy link
Contributor

Seconded. If we wanted to keep the feel of randomness, (shuffled) Sobol could be another good sampler.

@ym1906
Copy link
Collaborator Author

ym1906 commented Mar 19, 2025

Yes, I have already got a quick implementation working - I'll create a branch. It will be easy for users to change the sampler too. We can also do away with the config file.

That said @jonmaddock mentioned he might like to remove this feature altogether. I think it's still useful to have for quick and simple runs locally.

@ym1906 ym1906 self-assigned this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Convergence Solver or convergence-related problems New feature Introduction of a new model / feature
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants