New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Tests returning values #3597

Closed

timothy-nunn opened this issue Mar 20, 2025 · 0 comments · Fixed by #3607

Assignees

Contributor

timothy-nunn commented Mar 20, 2025 •

edited

Loading

Tests should not return any value and should only make asserts. This will cause an issue in the future:

/home/ubuntu/PROCESS/.venv/lib/python3.10/site-packages/_pytest/python.py:163: PytestReturnNotNoneWarning: 
Expected None, but unit/test_mfile2dict.py::test_value_read returned True, which will be an error in a 
future version of pytest.  Did you mean to use `assert` instead of `return`?

The text was updated successfully, but these errors were encountered:

timothy-nunn assigned timothy-nunn and clmould and unassigned timothy-nunn

clmould linked a pull request

that will close this issue

change test to assert instead of returning a value #3607

Merged

6 tasks

clmould mentioned this issue

change test to assert instead of returning a value #3607

Merged

6 tasks

timothy-nunn closed this as completed in #3607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment