Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 Documentation megathread #42

Open
11 of 12 tasks
SMijin opened this issue Dec 4, 2024 · 16 comments
Open
11 of 12 tasks

v2.0.0 Documentation megathread #42

SMijin opened this issue Dec 4, 2024 · 16 comments
Assignees
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@SMijin
Copy link
Contributor

SMijin commented Dec 4, 2024

Currently, the rewrite on dev-v2.0.0 is poorly documented. The following still remains to be done:

  • variable_container: some functions, though majority well documented
  • derivations: all
  • model_construction: all
  • stencils: all
  • integrators: all
  • io_support: all
  • crm_support: all
  • remkit_context: all
  • README
  • sphinx documentation: cleanup
  • sphinx documentation: basic tutorials
  • sphinx documentation: advanced tutorials
@SMijin SMijin self-assigned this Dec 4, 2024
@SMijin SMijin added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Dec 4, 2024
@SMijin
Copy link
Contributor Author

SMijin commented Dec 5, 2024

Most non-trivial variable functions now documented

@SMijin
Copy link
Contributor Author

SMijin commented Dec 9, 2024

Derivation constructors now documented.

@SMijin
Copy link
Contributor Author

SMijin commented Dec 10, 2024

Model construction documentation now added for most non-trivial functions and constructor. Also started adding class docstrings

@SMijin
Copy link
Contributor Author

SMijin commented Dec 10, 2024

Stencils basically fully documented now, mostly reused old documentation with a few updates.

@SMijin
Copy link
Contributor Author

SMijin commented Dec 11, 2024

Integrator documentation completed for most non-trivial functions and constructors

@sleigh2022
Copy link
Collaborator

sleigh2022 commented Dec 11, 2024

Possible bug: Evolved energy variable in Term Generators is missing $$ (dollar signs) around the variable when a latexRemap is passed, see crm_support.py line 1215.

This is not seen for evolved densities which is rendering correctly.

@SMijin
Copy link
Contributor Author

SMijin commented Jan 2, 2025

Added the $ escape characters to the line in question, should now render correctly.

@SMijin
Copy link
Contributor Author

SMijin commented Jan 2, 2025

IO_support now fully documented

@SMijin
Copy link
Contributor Author

SMijin commented Jan 2, 2025

Majority of crm_support now documented

@SMijin
Copy link
Contributor Author

SMijin commented Jan 2, 2025

Non-trivial remkit_context functions and classes documented now

@SMijin
Copy link
Contributor Author

SMijin commented Jan 3, 2025

First pass of v2.0.0 README complete

@SMijin
Copy link
Contributor Author

SMijin commented Jan 3, 2025

Started on Sphinx docs, they now compile, so the CI passes. Working on the basic tutorials now, meant to cover the full basic workflow + some bits. These are in addition to the runnable examples.

@SMijin
Copy link
Contributor Author

SMijin commented Jan 3, 2025

Updated Sphinx docs, first two tutorials complete.

@SMijin
Copy link
Contributor Author

SMijin commented Jan 9, 2025

7 basic tutorials now complete.

@sleigh2022
Copy link
Collaborator

Docstring for common_models.logicalBCModel - and by extension model_construction LBCModelboundData - should state that ionCurrent must be both Scalar and Derived, since this is a requirement of the LBCModelboundData.getitem method

@SMijin
Copy link
Contributor Author

SMijin commented Jan 10, 2025

Pushed commit that makes all scalar variables automatically derived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants