You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- I think we should change the following cpf fields as follows
all field that are like
cpf_amin_ipmax: Optional[float] = Field(
alias="generic_minor_radius_max_current",
description="(Generic) Minor radius at time of peak plasma current for MAST and MAST-U",
)
or
cpf_amin_truby: Optional[float] = Field(
alias="generic_minor_radius_ruby_time",
description="(Generic) Minor radius at time of Ruby TS for MAST only",
)
should have at between their name.
example generic_minor_radius_at_max_current, generic_minor_radius_at_ruby
the reason is because there are filed like
"thomsonDensityMax": {
"type": "number",
"description": "(Thomson) Peak Core Electron Density (Nd.YAG) for MAST and MAST-U"}
which does not mean at max.
But
"thomsonDensityMaxCurrent": {
"type": "number",
"description": "(Thomson) Core Electron Density (Nd.YAG) at time of Peak Current for MAST and MAST-U"
},
means at peak current
- For the case of generic_minor_radius_ruby_time, I suggest we remove time at the end because field that relates to time already have time at their end, e.g.
cpf_p20204: Optional[float] = Field(
alias="mcs_pshot_gdc_time",
description="(MCS Setup) Pre-Shot GDC duration for MAST only",
)
cpf_p20000: Optional[float] = Field(
alias="mcs_ss_number",
description="(MCS Setup) Shot sequence number for MAST only",
) => mcs_shot_sequence_no
The text was updated successfully, but these errors were encountered:
- Convert field names to camelCase
- I think we should change the following cpf fields as follows
all field that are like
cpf_amin_ipmax: Optional[float] = Field(
alias="generic_minor_radius_max_current",
description="(Generic) Minor radius at time of peak plasma current for MAST and MAST-U",
)
or
should have
at
between their name.example generic_minor_radius_at_max_current, generic_minor_radius_at_ruby
the reason is because there are filed like
which does not mean at max.
But
means at peak current
- For the case of generic_minor_radius_ruby_time, I suggest we remove time at the end because field that relates to time already have time at their end, e.g.
The text was updated successfully, but these errors were encountered: