Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some CPF-Fields name #110

Open
khalsz opened this issue Jan 30, 2025 · 0 comments
Open

Fixing some CPF-Fields name #110

khalsz opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@khalsz
Copy link
Collaborator

khalsz commented Jan 30, 2025

- Convert field names to camelCase

- I think we should change the following cpf fields as follows

all field that are like
cpf_amin_ipmax: Optional[float] = Field(
alias="generic_minor_radius_max_current",
description="(Generic) Minor radius at time of peak plasma current for MAST and MAST-U",
)
or

cpf_amin_truby: Optional[float] = Field(
    alias="generic_minor_radius_ruby_time",
    description="(Generic) Minor radius at time of Ruby TS for MAST only",
)

should have at between their name.
example generic_minor_radius_at_max_current, generic_minor_radius_at_ruby

the reason is because there are filed like

"thomsonDensityMax": {
  "type": "number",
  "description": "(Thomson) Peak Core Electron Density (Nd.YAG) for MAST and MAST-U"}

which does not mean at max.
But

"thomsonDensityMaxCurrent": {
  "type": "number",
  "description": "(Thomson) Core Electron Density (Nd.YAG) at time of Peak Current for MAST and MAST-U"
},

means at peak current

- For the case of generic_minor_radius_ruby_time, I suggest we remove time at the end because field that relates to time already have time at their end, e.g.

cpf_p20204: Optional[float] = Field(
    alias="mcs_pshot_gdc_time",
    description="(MCS Setup) Pre-Shot GDC duration for MAST only",
)


cpf_p20000: Optional[float] = Field(
    alias="mcs_ss_number",
    description="(MCS Setup) Shot sequence number for MAST only",
) => mcs_shot_sequence_no
@khalsz khalsz added the enhancement New feature or request label Jan 30, 2025
@khalsz khalsz self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant