chore: use defineLazyProperty instead, assert options.tsconfig in test cases

Author: JounQin

.github/workflows/ci.yml

@@ -63,7 +63,7 @@ jobs:
           PARSER_NO_WATCH: true
 
       - name: Codecov
-        uses: codecov/codecov-action@ad3126e916f78f00edff4ed0317cf185271ccc2d # v5.4.2
+        uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
 

src/utils/export-map.ts

@@ -94,7 +94,7 @@ function getTsconfigWithContext(context: ChildContext | RuleContext) {
   const parserOptions = context.parserOptions || {}
   let tsconfigRootDir = parserOptions.tsconfigRootDir
   const project = parserOptions.project
-  const cacheKey = stableHash({ tsconfigRootDir, project })
+  const cacheKey = stableHash([tsconfigRootDir, project])
   let tsConfig: TsConfigJsonResolved | null | undefined
   if (tsconfigCache.has(cacheKey)) {
     tsConfig = tsconfigCache.get(cacheKey)!
@@ -195,11 +195,11 @@ export class ExportMap {
   static get(source: string, context: RuleContext) {
     const tsconfig = lazy(() => getTsconfigWithContext(context))
 
-    const path = resolve(source, context, {
-      get tsconfig() {
-        return tsconfig()
-      },
-    })
+    const path = resolve(
+      source,
+      context,
+      defineLazyProperty({}, 'tsconfig', tsconfig),
+    )
     if (path == null) {
       return null
     }
@@ -286,11 +286,13 @@ export class ExportMap {
     const namespaces = new Map</* identifier */ string, /* source */ string>()
 
     function remotePath(value: string) {
-      return relative(value, filepath, context.settings, context, {
-        get tsconfig() {
-          return tsconfig()
-        },
-      })
+      return relative(
+        value,
+        filepath,
+        context.settings,
+        context,
+        defineLazyProperty({}, 'tsconfig', tsconfig),
+      )
     }
 
     function resolveImport(value: string) {

src/utils/resolve.ts

@@ -14,6 +14,7 @@ import type {
   RuleContext,
 } from '../types.js'
 
+import { defineLazyProperty } from './lazy-value.js'
 import {
   normalizeConfigResolvers,
   resolveWithLegacyResolver,
@@ -294,11 +295,7 @@ export function importXResolverCompat(
         modulePath,
         sourceFile,
         options.context,
-        {
-          get tsconfig() {
-            return options.tsconfig
-          },
-        },
+        defineLazyProperty({}, 'tsconfig', () => options.tsconfig),
       )
       return resolved
     },

test/fixtures/foo-bar-resolver-no-version.js

@@ -11,4 +11,15 @@ exports.resolveImport = function (modulePath, sourceFile, config, _, options) {
   }
   assert.ok(!_, 'the 4th argument must be undefined')
   assert.ok(options.context.cwd, 'the `context.cwd` must be present')
+  if (options.context.parserOptions?.project) {
+    assert.ok(
+      options.tsconfig,
+      'the `tsconfig` must be present when `parserOptions.project` is set'
+    )
+  } else {
+    assert.ok(
+      !options.tsconfig,
+      'the `tsconfig` must not be present when `parserOptions.project` is not set'
+    )
+  }
 }

test/fixtures/foo-bar-resolver-v1.js

@@ -11,6 +11,17 @@ exports.resolveImport = function (modulePath, sourceFile, config, _, options) {
   }
   assert.ok(!_, 'the 4th argument must be undefined')
   assert.ok(options.context.cwd, 'the `context` must be present')
+  if (options.context.parserOptions?.project) {
+    assert.ok(
+      options.tsconfig,
+      'the `tsconfig` must be present when `parserOptions.project` is set'
+    )
+  } else {
+    assert.ok(
+      !options.tsconfig,
+      'the `tsconfig` must not be present when `parserOptions.project` is not set'
+    )
+  }
 }
 
 exports.interfaceVersion = 1

test/fixtures/foo-bar-resolver-v2.js

@@ -11,6 +11,17 @@ exports.resolve = function (modulePath, sourceFile, config, _, options) {
   }
   assert.ok(!_, 'the 4th argument must be undefined')
   assert.ok(options.context.cwd, 'the `context.cwd` must be present')
+  if (options.context.parserOptions?.project) {
+    assert.ok(
+      options.tsconfig,
+      'the `tsconfig` must be present when `parserOptions.project` is set'
+    )
+  } else {
+    assert.ok(
+      !options.tsconfig,
+      'the `tsconfig` must not be present when `parserOptions.project` is not set'
+    )
+  }
   return { found: false }
 }
 

test/fixtures/foo-bar-resolver-v3.js

@@ -16,6 +16,17 @@ exports.foobarResolver = {
       throw new Error('foo-bar-resolver-v3 resolve test exception')
     }
     assert.ok(options.context.cwd, 'the `context.cwd` must be present')
+    if (options.context.parserOptions?.project) {
+      assert.ok(
+        options.tsconfig,
+        'the `tsconfig` must be present when `parserOptions.project` is set'
+      )
+    } else {
+      assert.ok(
+        !options.tsconfig,
+        'the `tsconfig` must not be present when `parserOptions.project` is not set'
+      )
+    }
     return { found: false }
   },
 }