-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Webhook Secret #33
Comments
To my knowledge there is no validation payload, since the secret is sent in clear text. Gitlab documentation: https://docs.gitlab.com/ee/user/project/integrations/webhooks.html We would need this to make it really secure: Because right now the "a lot more safe" part is not really granted. |
We have something similar in an other tool (receiving web-hooks from SonarQube / SonarCloud) There is an optional config for the secret: And then when we get an event we make sure that is a secret is configured we should have a In the case of GitLab this would be even simpler since we would just have to check for the presence of the |
We accept a PR for this feature request |
GitLab support "Secret token" when sending webhooks:
Used to validate received payloads. Sent with the request in the X-Gitlab-Token HTTP header.
Adding this support into ucascade would make it a lot more safe
The text was updated successfully, but these errors were encountered: