Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness when multiple approvals are required #43

Open
fbpe opened this issue Mar 6, 2025 · 0 comments
Open

Improve robustness when multiple approvals are required #43

fbpe opened this issue Mar 6, 2025 · 0 comments
Assignees

Comments

@fbpe
Copy link
Contributor

fbpe commented Mar 6, 2025

Right now ucascade checks the approvals_left value right after approving the MR. In case the MR needs multiple approvals, this might not give enough time for Gitlab to report the correct value, as the MR might still be in approvals_syncing status. This results in the MR getting stuck open due to missing approvals.

What we should do is to move the isMergeRequestApproved check to after the waiting loop for the MR being ready.

@fbpe fbpe self-assigned this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant