You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now ucascade checks the approvals_left value right after approving the MR. In case the MR needs multiple approvals, this might not give enough time for Gitlab to report the correct value, as the MR might still be in approvals_syncing status. This results in the MR getting stuck open due to missing approvals.
What we should do is to move the isMergeRequestApproved check to after the waiting loop for the MR being ready.
The text was updated successfully, but these errors were encountered:
Right now ucascade checks the
approvals_left
value right after approving the MR. In case the MR needs multiple approvals, this might not give enough time for Gitlab to report the correct value, as the MR might still be inapprovals_syncing
status. This results in the MR getting stuck open due to missing approvals.What we should do is to move the isMergeRequestApproved check to after the waiting loop for the MR being ready.
The text was updated successfully, but these errors were encountered: