From 5e317983176f98370f1c59660764a2a52a12f918 Mon Sep 17 00:00:00 2001 From: Kris Jordan Date: Tue, 21 Jan 2025 20:43:46 -0500 Subject: [PATCH] Order rooms by their name by default --- backend/services/room.py | 2 +- backend/test/services/room_test.py | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/backend/services/room.py b/backend/services/room.py index e4c18f5cb..f22d34a14 100644 --- a/backend/services/room.py +++ b/backend/services/room.py @@ -40,7 +40,7 @@ def all(self) -> list[RoomDetails]: list[RoomDetails]: List of all `RoomDetails` """ # Select all entries in `Room` table - query = select(RoomEntity).order_by(RoomEntity.capacity) + query = select(RoomEntity).order_by(RoomEntity.nickname) entities = self._session.scalars(query).all() # Convert entries to a model and return diff --git a/backend/test/services/room_test.py b/backend/test/services/room_test.py index 9a8065578..5f8713909 100644 --- a/backend/test/services/room_test.py +++ b/backend/test/services/room_test.py @@ -1,4 +1,5 @@ """Tests for Coworking Rooms Service.""" + from unittest.mock import create_autospec import pytest from backend.services.exceptions import ( @@ -32,10 +33,10 @@ def test_list(room_svc: RoomService): assert isinstance(rooms[0], RoomDetails) -def test_list_ordered_by_capacity(room_svc: RoomService): +def test_list_ordered_by_name(room_svc: RoomService): rooms = room_svc.all() for i in range(1, len(rooms)): - assert rooms[i - 1].capacity <= rooms[i].capacity + assert rooms[i - 1].nickname <= rooms[i].nickname def test_get_by_id(room_svc: RoomService):