Include JS files in TypeScript build

Author: ramosbugs

.eslintrc-ts.js

@@ -0,0 +1,56 @@
+// Copyright (c) 2022-2023 Developer Innovations, LLC
+
+module.exports = {
+  extends: [
+    "plugin:@typescript-eslint/recommended",
+    "plugin:@typescript-eslint/recommended-requiring-type-checking",
+    "plugin:import/typescript",
+  ],
+  parser: "@typescript-eslint/parser",
+  parserOptions: {
+    // Find the tsconfig.json nearest each source file.
+    project: true,
+  },
+  plugins: ["@typescript-eslint"],
+  rules: {
+    "@typescript-eslint/explicit-function-return-type": ["error"],
+    "@typescript-eslint/explicit-module-boundary-types": ["error"],
+    "@typescript-eslint/no-unused-expressions": ["error"],
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        argsIgnorePattern: "^_",
+        caughtErrorsIgnorePattern: "^_",
+        varsIgnorePattern: "^_",
+      },
+    ],
+    "@typescript-eslint/no-use-before-define": ["error", { functions: false }],
+    "@typescript-eslint/strict-boolean-expressions": [
+      "error",
+      {
+        allowString: false,
+        allowNumber: false,
+        allowNullableObject: false,
+      },
+    ],
+    "@typescript-eslint/switch-exhaustiveness-check": ["error"],
+  },
+  overrides: [
+    {
+      files: ["**/*.js", "**/*.cjs", "**/*.mjs"],
+      rules: {
+        // JS files don't have explicit types, and this lint rule fails even if they have doc
+        // comment type annotations.
+        "@typescript-eslint/explicit-function-return-type": "off",
+        "@typescript-eslint/explicit-module-boundary-types": "off",
+        // Allow require() in JS files (most of which are CommonJS, not ESM).
+        "@typescript-eslint/no-var-requires": "off",
+      },
+    },
+  ],
+  settings: {
+    "import/resolver": {
+      typescript: true,
+    },
+  },
+};

.eslintrc.js

@@ -6,52 +6,34 @@ module.exports = {
   },
   extends: [
     "eslint:recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:@typescript-eslint/recommended-requiring-type-checking",
     "plugin:import/errors",
     "plugin:import/warnings",
-    "plugin:import/typescript",
   ],
-  parser: "@typescript-eslint/parser",
   parserOptions: {
-    // Find the tsconfig.json nearest each source file.
-    project: true,
+    // Support `??` operator.
+    ecmaVersion: 2020,
   },
-  plugins: ["@typescript-eslint", "import"],
+  plugins: ["import"],
   root: true,
   rules: {
     curly: ["error", "all"],
     eqeqeq: ["error", "always"],
     "no-implicit-coercion": ["error"],
     // https://github.com/eslint/eslint/blob/master/docs/rules/no-sequences.md#when-not-to-use-it
     "no-restricted-syntax": ["error", "SequenceExpression"],
-    "prefer-const": ["error", { destructuring: "all" }],
-    "require-await": ["error"],
-    "@typescript-eslint/explicit-function-return-type": ["error"],
-    "@typescript-eslint/explicit-module-boundary-types": ["error"],
-    "@typescript-eslint/no-unused-expressions": ["error"],
-    "@typescript-eslint/no-unused-vars": [
+    "no-unused-vars": [
       "error",
       {
         argsIgnorePattern: "^_",
         caughtErrorsIgnorePattern: "^_",
         varsIgnorePattern: "^_",
       },
     ],
-    "@typescript-eslint/no-use-before-define": ["error", { functions: false }],
-    "@typescript-eslint/strict-boolean-expressions": [
-      "error",
-      {
-        allowString: false,
-        allowNumber: false,
-        allowNullableObject: false,
-      },
-    ],
-    "@typescript-eslint/switch-exhaustiveness-check": ["error"],
+    "prefer-const": ["error", { destructuring: "all" }],
+    "require-await": ["error"],
   },
   settings: {
     "import/resolver": {
-      typescript: true,
       node: true,
     },
   },

packages/jest-plugin/.eslintrc.js

@@ -1,11 +1,12 @@
 // Copyright (c) 2023 Developer Innovations, LLC
 
 module.exports = {
+  extends: ["../../.eslintrc-ts.js"],
   overrides: [
     {
       // Disable some rules that fail for vendored Jest code. If we fix these, it'll be harder to
       // merge upstream changes.
-      files: ["src/vendored/**/*.ts"],
+      files: ["src/vendored/**"],
       rules: {
         "@typescript-eslint/no-inferrable-types": "off",
         "@typescript-eslint/no-unsafe-member-access": "off",

packages/jest-plugin/rollup.config.mjs

@@ -30,6 +30,8 @@ export default {
       "@unflakable/js-api/consts",
       "@unflakable/plugins-common",
     ].includes(id),
+  // Unclear why this is necessary.
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
   plugins: [
     pluginCommonJs(),
     pluginJson(),

packages/jest-plugin/test/integration-input/tsconfig.json

@@ -5,7 +5,5 @@
     // Some versions of Jest (e.g., 28.0.0) have internally broken types.
     "skipLibCheck": true
   },
-  "include": [
-    "src/**/*.ts"
-  ]
+  "include": ["jest.config.js", "src"]
 }

packages/jest-plugin/tsconfig.json

@@ -15,5 +15,11 @@
     "skipLibCheck": true,
     "sourceMap": true
   },
-  "include": ["src/**/*.ts", "window.d.ts"]
+  "include": [
+    ".eslintrc.js",
+    "src",
+    "test/.eslintrc.js",
+    "rollup.config.mjs",
+    "window.d.ts"
+  ]
 }

packages/js-api/.eslintrc.js

@@ -0,0 +1,5 @@
+// Copyright (c) 2023 Developer Innovations, LLC
+
+module.exports = {
+  extends: ["../../.eslintrc-ts.js"],
+};

packages/js-api/package.json

@@ -25,7 +25,7 @@
     "@types/node-fetch": "^2.6.2"
   },
   "scripts": {
-    "build": "tsc --build",
+    "build": "rm -rf dist && tsc --noEmit && tsc -p src",
     "build:watch": "tsc --build --watch"
   }
 }

packages/js-api/src/tsconfig.json

@@ -0,0 +1,12 @@
+{
+  "extends": "../../../tsconfig.json",
+  "compilerOptions": {
+    "outDir": "../dist/",
+    "declaration": true,
+    // Removes DOM types.
+    "lib": ["ES2019"],
+    // Avoids conflicting global definitions from, e.g., jasmine.
+    "types": ["node"]
+  },
+  "include": ["."]
+}

packages/js-api/tsconfig.json

@@ -1,12 +1,10 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "outDir": "dist/",
-    "declaration": true,
     // Removes DOM types.
     "lib": ["ES2019"],
     // Avoids conflicting global definitions from, e.g., jasmine.
     "types": ["node"]
   },
-  "include": ["src/**/*.ts"]
+  "include": [".eslintrc.js"]
 }