From 06615c5bbb2e17bfbaa59b17652a3b2c0a329c6d Mon Sep 17 00:00:00 2001 From: Daniel Date: Thu, 27 Jul 2017 12:43:13 -0700 Subject: [PATCH 1/3] Pass subnets as list since that is var type - subnets should be receieved as a list type already so can be passed directly without placing inside another list. --- group/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/group/main.tf b/group/main.tf index 0555fe0..41f9c42 100644 --- a/group/main.tf +++ b/group/main.tf @@ -100,7 +100,7 @@ module "asg" { asg_name_override = "${var.asg_name_override}" ### VPC parameters - subnets = ["${var.subnets}"] + subnets = "${var.subnets}" ### LC parameters lc_id = "${module.lc.lc_id}" From 8b9508059d110cc5483ec5a863334d871b45cdb0 Mon Sep 17 00:00:00 2001 From: Daniel Date: Thu, 27 Jul 2017 12:52:05 -0700 Subject: [PATCH 2/3] Updating for latest covalence requirements - Removed packer/terraform dir in env.docker since this is no longer needed. - Removed packer_tasks from the Rakefile since this was also deprecated in the latest covalence. --- .env.docker | 2 -- Rakefile | 1 - 2 files changed, 3 deletions(-) diff --git a/.env.docker b/.env.docker index bc7333f..737bc09 100644 --- a/.env.docker +++ b/.env.docker @@ -1,6 +1,4 @@ AWS_REGION=us-east-2 -COVALENCE_PACKER_DIR=./ -COVALENCE_TERRAFORM_DIR=./ COVALENCE_TEST_ENVS=basic CHECKPOINT_DISABLE=1 GODEBUG=netdns=cgo diff --git a/Rakefile b/Rakefile index 24c77b4..b0d99d7 100644 --- a/Rakefile +++ b/Rakefile @@ -1,4 +1,3 @@ require 'rake' require 'covalence/environment_tasks' -require 'covalence/packer_tasks' require 'covalence/spec_tasks' From 727a15caa4620101fb51fa2dac2718fe46f71349 Mon Sep 17 00:00:00 2001 From: Daniel Date: Wed, 4 Oct 2017 13:58:42 -0700 Subject: [PATCH 3/3] Updating README and tests **NOTE: This would be a breaking change for usage of this module with a comma separated string list. ``` ["${split(",",var.subnet_ids)}"] ``` To convert to a list would fail since it would already be of type list. --- README.md | 4 ++-- data/globals.yaml | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 8a89988..e7e9e35 100644 --- a/README.md +++ b/README.md @@ -165,7 +165,7 @@ module "asg" { # VPC parameters region = "us-east-1" - subnets = "subnet-3315e85a,subnet-3bbaaf43,subnet-ec1326a6" + subnets = ["subnet-3315e85a","subnet-3bbaaf43","subnet-ec1326a6"] vpc_id = "vpc-0f986c66" # LC parameters @@ -206,7 +206,7 @@ module "asg" { # VPC parameters region = "us-east-1" - subnets = "subnet-3315e85a,subnet-3bbaaf43,subnet-ec1326a6" + subnets = ["subnet-3315e85a","subnet-3bbaaf43","subnet-ec1326a6"] vpc_id = "vpc-0f986c66" # LC parameters diff --git a/data/globals.yaml b/data/globals.yaml index 5ab8578..01fe884 100644 --- a/data/globals.yaml +++ b/data/globals.yaml @@ -8,4 +8,7 @@ tf_state_region: 'us-east-2' ## VPC vpc_id: 'vpc-0f986c66' vpc_region: 'us-east-2' -vpc_subnets: 'subnet-3315e85a,subnet-3bbaaf43,subnet-ec1326a6' +vpc_subnets: + - 'subnet-3315e85a' + - 'subnet-3bbaaf43' + - 'subnet-ec1326a6'