Skip to content

Commit 8e2310d

Browse files
committed
refactor(diagram): remove unused edge types and method
Clean up CodeTopologyEntityEdge by deleting predefined edge constants and the unused getEdgeData method. Simplify getQualifiedName implementation in CodeTopologyVfsResolver.
1 parent b757d4a commit 8e2310d

File tree

2 files changed

+2
-34
lines changed

2 files changed

+2
-34
lines changed

exts/ext-diagram/src/241/main/kotlin/cc/unitmesh/diagram/diagram/CodeTopologyVfsResolver.kt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,7 @@ import cc.unitmesh.diagram.model.GraphNodeData
1010
*/
1111
class CodeTopologyVfsResolver : DiagramVfsResolver<GraphNodeData> {
1212

13-
override fun getQualifiedName(data: GraphNodeData?): String? {
14-
if (data == null) return null
15-
16-
val name = data.getName()
17-
return if (name.isNotEmpty()) name else null
18-
}
13+
override fun getQualifiedName(data: GraphNodeData?): String? = data?.getName()
1914

2015
override fun resolveElementByFQN(fqn: String, project: Project): GraphNodeData? {
2116
// For now, we don't support resolving elements by FQN

exts/ext-diagram/src/241/main/kotlin/cc/unitmesh/diagram/diagram/graph/CodeTopologyEntityEdge.kt

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -66,35 +66,8 @@ class CodeTopologyEntityEdge(
6666

6767
return builder.create()
6868
}
69-
70-
// Predefined relationship types for common Graphviz edge styles
71-
val DIRECTED_EDGE = DiagramRelationshipInfoAdapter.Builder()
72-
.setName("DIRECTED")
73-
.setLineType(DiagramLineType.SOLID)
74-
.setSourceArrow(DiagramRelationshipInfo.NONE)
75-
.setTargetArrow(DiagramRelationshipInfo.ANGLE)
76-
.create()
77-
78-
val UNDIRECTED_EDGE = DiagramRelationshipInfoAdapter.Builder()
79-
.setName("UNDIRECTED")
80-
.setLineType(DiagramLineType.SOLID)
81-
.setSourceArrow(DiagramRelationshipInfo.NONE)
82-
.setTargetArrow(DiagramRelationshipInfo.NONE)
83-
.create()
84-
85-
val DASHED_EDGE = DiagramRelationshipInfoAdapter.Builder()
86-
.setName("DASHED")
87-
.setLineType(DiagramLineType.DASHED)
88-
.setSourceArrow(DiagramRelationshipInfo.NONE)
89-
.setTargetArrow(DiagramRelationshipInfo.ANGLE)
90-
.create()
9169
}
92-
93-
/**
94-
* Get the edge data
95-
*/
96-
fun getEdgeData(): GraphEdgeData = edgeData
97-
70+
9871
override fun equals(other: Any?): Boolean {
9972
if (this === other) return true
10073
if (other !is CodeTopologyEntityEdge) return false

0 commit comments

Comments
 (0)