All mutations need to have toast.error

[harshsbhat]

Preliminary Checks

• I have reviewed the documentation: https://unkey.com/docs

• I have searched for existing issues: https://github.com/unkeyed/unkey/issues

• This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

I noticed there are multiple mutations where if they fail we are not logging a proper error message using the toast. Which means that the user won't get a success/error toast and the action won't take place either. I have listed the exact mutations here.

-createPermission
-updatePermission
-deletePermission
-deleteRole
-updateRole
-ratelimit.override.create
-ratelimit.override.update
-ratelimit.override.delete

-deleteNamespace
-updateNamespace
-workspace updateName 
-workspace.optIntoBeta

Steps to Reproduce

1. Go to https://app.unkey.com/ratelimits/[namespaceId]/settings
2. Rename the namespace
3. It doesn't display the error in toast nor does it rename the namespace

Expected behavior

It should rename the namespace and display a proper toast message.

Other information

No response

Screenshots

Version info

- OS:
- Node:
- npm:

[linear]

ENG-1387 Renaming namespace not working. ( toast is broken too )

[harshsbhat]

I plan to work on this if it gets approved. Please don't assign yourself

[chronark]

I plan to work on this if it gets approved. Please don't assign yourself

don't try to reserve this please, it's unfair to others,
I'd appreciate if you'd wrap up your other issues first

[chronark]

I can't reproduce it
https://share.cleanshot.com/s5LdYKQ0

[harshsbhat]

I got the reason why it's happening. It's because I was trying to rename it to a name that already exists.

( I didn't know that if I use a name in SDK initialization without having a namespace it creates one automatically )

But the toast problem still exists then

[chronark]

( I didn't know that if I use a name in SDK initialization without having a namespace it creates one automatically )

that's not the SDK, but the API where this happens.

OK so the issue is renaming when the new name collides with an existing one. We need to return a better error from trpc and make the toast work

also there seems to be no loading indicator on the save button

[chronark]

/award 150

[oss-gg]

Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat

[Vardhaman619]

/assign

[oss-gg]

Assigned to @Vardhaman619! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[harshsbhat]

/assign

[oss-gg]

Assigned to @harshsbhat! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[harshsbhat]

I have unassigned. Its open if anyone wants to take it

[AkshayBandi027]

/assign

[oss-gg]

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

[harshsbhat]

@AkshayBandi027 I unassigned myself so that someone without any issue in hand can work on this. Please

[harshsbhat]

/assign

[oss-gg]

Assigned to @harshsbhat! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[harshsbhat]

assigning this as my work in the other PR is done and just needs a few reviews

[harshsbhat]

@chronark as I was solving this. I noticed there are multiple mutations where if they fail we are not logging a proper error message using the toast. Which means that the user won't get a success/error toast and the action won't take place either. I have listed the exact mutations here. Wdyt? Should we update this issue to solve the following too?

-createPermission
-updatePermission
-deletePermission
-deleteRole
-updateRole
-ratelimit.override.create
-ratelimit.override.update
-ratelimit.override.delete

-deleteNamespace
-updateNamespace
-workspace updateName 
-workspace.optIntoBeta

[chronark]

yes please

[oss-gg]

@Vardhaman619, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

[oss-gg]

@Vardhaman619, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.