-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode key creation bug #2823
Comments
Should we just make it a bit lighter? @ogzhanolguncu |
can you assign me @ogzhanolguncu |
@codervinod123 @ogzhanolguncu I don't get it. Do we need to change the entire shadcn UI for switch? Because this problem is everywhere and not just create keys. |
I haven't checked the issue thoroughly, but you are probably right. We are migrating to a new design in 2025 as quickly as possible, which means we'll rewrite this component soon. I think as a simple fix, we can replace the colors with our new color scheme such as 'gray-3', 'gray-4', or 'accent-4', whichever is appropriate. @codervinod123 @harshsbhat, either of you can tackle this issue whenever you have time. |
hi @ogzhanolguncu i don't believe we need to change the base components for this. just needed to use the appropriate color based on the state of the switch. i have gone ahead and created a PR for the same. can you please review? |
Preliminary Checks
I have reviewed the documentation: https://unkey.com/docs
I have searched for existing issues: https://github.com/unkeyed/unkey/issues
This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.
Reproduction / Replay Link (Optional)
No response
Issue Summary
When creating a new key toggle buttons look total black in dark mode.
Steps to Reproduce
Expected behavior
They should use appropriate colors depending on the system or selected color theme.
Other information
We are migrating to a new color scheme. Check internal/ui package to see new colors like
accent-5
,gray-7
Screenshots
Version info
The text was updated successfully, but these errors were encountered: