Merge: Cloudflare deployment fixes from cursor/fix-cloudflare-deploy-main-only-9617#4
Merged
unnita1235-code merged 1 commit intoMay 23, 2026
Conversation
…ssing Co-authored-by: Unni T A <unnita1235-code@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainonly (nodevelop/master).Root cause
deploy.ymlfailed immediately invalidate-deploy-configwhenCLOUDFLARE_API_TOKEN(and related secrets) were not present in the target GitHub Environment. This blocked push checks even when deployment credentials were not configured.Changes
.github/workflows/deploy.ymlon.push.brancheschanged from[main, develop]to[main].validate-deploy-configjob outputcan_deploy.can_deploy=false,if: needs.validate-deploy-config.outputs.can_deploy == 'true'topre-deploy-checksso deploy pipeline only proceeds when secrets are available.mainproduction mapping..github/workflows/github-action.ymlpushbranches changed from[main, master, develop]to[main].pull_requestbranches changed from[main, master, develop]to[main].Expected outcome
mainno longer fail invalidate-deploy-configsolely because deployment secrets are missing.mainonly.