refactor(disks): replace store dependency with ConfigService in DisksService

- Refactored `DisksService` to utilize `ConfigService` for accessing disk state data instead of the previously injected store.
- Updated unit tests in `disks.service.spec.ts` to mock `ConfigService` and verify interactions, ensuring proper functionality with the new implementation.
- Enhanced test coverage by checking various scenarios for disk retrieval using the configuration service.

Author: elibosley

api/src/unraid-api/graph/resolvers/disks/disks.service.spec.ts

@@ -1,3 +1,4 @@
+import { ConfigService } from '@nestjs/config';
 import { Test, TestingModule } from '@nestjs/testing';
 
 import type { Systeminformation } from 'systeminformation';
@@ -6,7 +7,6 @@ import { blockDevices, diskLayout } from 'systeminformation';
 // Vitest imports
 import { beforeEach, describe, expect, it, vi } from 'vitest';
 
-import { store } from '@app/store/index.js';
 import {
     ArrayDisk,
     ArrayDiskStatus,
@@ -30,11 +30,6 @@ vi.mock('@app/utils.js', () => ({
         return { data, errors: [] };
     }),
 }));
-vi.mock('@app/store/index.js', () => ({
-    store: {
-        getState: vi.fn(),
-    },
-}));
 
 // Remove explicit type assertions for mocks
 const mockExeca = execa as any; // Using 'any' for simplicity with complex mock setups
@@ -44,6 +39,7 @@ const mockBatchProcess = batchProcess as any;
 
 describe('DisksService', () => {
     let service: DisksService;
+    let configService: ConfigService;
 
     // Mock ArrayDisk data from state
     const mockArrayDisks: ArrayDisk[] = [
@@ -305,21 +301,28 @@ describe('DisksService', () => {
         // Reset mocks before each test using vi
         vi.clearAllMocks();
 
-        // Setup default store state
-        vi.mocked(store.getState).mockReturnValue({
-            paths: {
-                states: 'dev/states',
-            },
-            emhttp: {
-                disks: mockArrayDisks,
-            },
-        } as any);
+        // Create mock ConfigService
+        const mockConfigService = {
+            get: vi.fn().mockImplementation((key: string, defaultValue?: any) => {
+                if (key === 'store.emhttp.disks') {
+                    return mockArrayDisks;
+                }
+                return defaultValue;
+            }),
+        };
 
         const module: TestingModule = await Test.createTestingModule({
-            providers: [DisksService],
+            providers: [
+                DisksService,
+                {
+                    provide: ConfigService,
+                    useValue: mockConfigService,
+                },
+            ],
         }).compile();
 
         service = module.get<DisksService>(DisksService);
+        configService = module.get<ConfigService>(ConfigService);
 
         // Setup default mock implementations
         mockDiskLayout.mockResolvedValue(mockDiskLayoutData);
@@ -347,7 +350,7 @@ describe('DisksService', () => {
 
             expect(mockDiskLayout).toHaveBeenCalledTimes(1);
             expect(mockBlockDevices).toHaveBeenCalledTimes(1);
-            expect(store.getState).toHaveBeenCalledTimes(1);
+            expect(configService.get).toHaveBeenCalledWith('store.emhttp.disks', []);
             expect(mockBatchProcess).toHaveBeenCalledTimes(1);
 
             expect(disks).toHaveLength(mockDiskLayoutData.length);
@@ -380,14 +383,12 @@ describe('DisksService', () => {
         });
 
         it('should handle empty state gracefully', async () => {
-            vi.mocked(store.getState).mockReturnValue({
-                paths: {
-                    states: 'dev/states',
-                },
-                emhttp: {
-                    disks: [],
-                },
-            } as any);
+            vi.mocked(configService.get).mockImplementation((key: string, defaultValue?: any) => {
+                if (key === 'store.emhttp.disks') {
+                    return [];
+                }
+                return defaultValue;
+            });
 
             const disks = await service.getDisks();
 
@@ -406,14 +407,12 @@ describe('DisksService', () => {
                 id: '  S4ENNF0N123456  ', // spaces around ID
             };
 
-            vi.mocked(store.getState).mockReturnValue({
-                paths: {
-                    states: 'dev/states',
-                },
-                emhttp: {
-                    disks: disksWithSpaces,
-                },
-            } as any);
+            vi.mocked(configService.get).mockImplementation((key: string, defaultValue?: any) => {
+                if (key === 'store.emhttp.disks') {
+                    return disksWithSpaces;
+                }
+                return defaultValue;
+            });
 
             const disks = await service.getDisks();
             const disk = disks.find((d) => d.id === 'S4ENNF0N123456');
@@ -447,14 +446,11 @@ describe('DisksService', () => {
             });
         });
 
-        it('should use state data instead of reloading config file', async () => {
-            const getStateSpy = vi.spyOn(store, 'getState');
-
+        it('should use ConfigService to get state data', async () => {
             await service.getDisks();
 
-            expect(getStateSpy).toHaveBeenCalled();
-            // Verify we're accessing the state exactly once
-            expect(store.getState).toHaveBeenCalledTimes(1);
+            // Verify we're accessing the state through ConfigService
+            expect(configService.get).toHaveBeenCalledWith('store.emhttp.disks', []);
         });
 
         it('should handle empty disk layout or block devices', async () => {

api/src/unraid-api/graph/resolvers/disks/disks.service.ts

@@ -1,10 +1,10 @@
 import { Injectable, NotFoundException } from '@nestjs/common';
+import { ConfigService } from '@nestjs/config';
 
 import type { Systeminformation } from 'systeminformation';
 import { execa } from 'execa';
 import { blockDevices, diskLayout } from 'systeminformation';
 
-import { store } from '@app/store/index.js';
 import { ArrayDisk } from '@app/unraid-api/graph/resolvers/array/array.model.js';
 import {
     Disk,
@@ -16,6 +16,7 @@ import { batchProcess } from '@app/utils.js';
 
 @Injectable()
 export class DisksService {
+    constructor(private readonly configService: ConfigService) {}
     public async getTemperature(device: string): Promise<number | null> {
         try {
             const { stdout } = await execa('smartctl', ['-A', device]);
@@ -139,8 +140,7 @@ export class DisksService {
         const partitions = await blockDevices().then((devices) =>
             devices.filter((device) => device.type === 'part')
         );
-        const { emhttp } = store.getState();
-        const arrayDisks = emhttp.disks;
+        const arrayDisks = this.configService.get<ArrayDisk[]>('store.emhttp.disks', []);
         const { data } = await batchProcess(await diskLayout(), async (disk) =>
             this.parseDisk(disk, partitions, arrayDisks)
         );