-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of DefaultEmitter #35
Comments
@lebensterben if you're looking to contribute to html5gum I think this would be a good start to get some overlap between lychee contributors and html5gum contributors as it also provides immediate value to lychee and hyperlink (if performance is improved by sufficient margin) Let me know if you are interested in that, also happy to answer any questions. |
Why not? Is strtendril not working? |
@Ygg01 while lurking the servo zulip and the public issue tracker, my impression was that author simon sapin would like to rewrite the library or get rid of its usage in html5ever, eg servo/tendril#58 I also think it's fine if users of html5gum get only passable performance out of the box, as long as there's options to tweak things to optimal performance. |
Hmm, perhaps it's possible to use |
I believe long-term, html5gum should implement a treebuilder + dom. so it may be wiser to reevaluate the discussion about string allocation until after then. |
While implementing lycheeverse/lychee#480 I realized how slow the default emitter really is. It makes link extraction 10-40% slower than html5ever. It is currently not really possible to beat html5ever at all unless a custom emitter is implemented.
We could:
The text was updated successfully, but these errors were encountered: