Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sendDatexViaHTTPChannel() asynchronous #107

Open
asbng opened this issue Jun 7, 2024 · 1 comment
Open

Make sendDatexViaHTTPChannel() asynchronous #107

asbng opened this issue Jun 7, 2024 · 1 comment

Comments

@asbng
Copy link
Member

asbng commented Jun 7, 2024

fetch(origin + "/datex-http", {
is not prefixed with the await keyword. The sendDatexViaHTTPChannel function should be marked as async.

@jonasstrehle
Copy link
Member

We should probably return the fetch promise without marking the method as async. In theory there is no need to await the result of fetch, but if we want to await the send we can do that at the specific point in code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants