Skip to content

[Bug/Feature] Allow msgpack as response type (de-serialize to JSON) #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ino-josh opened this issue Oct 4, 2023 · 6 comments · May be fixed by #4704
Open

[Bug/Feature] Allow msgpack as response type (de-serialize to JSON) #372

ino-josh opened this issue Oct 4, 2023 · 6 comments · May be fixed by #4704
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community contribution is welcome long-term-goal module-request

Comments

@ino-josh
Copy link

ino-josh commented Oct 4, 2023

Currently, getting a response that is msgpack formatted results in the application window just going completely blank (at least that is what is happening for me). Likely a result of Bruno trying to parse the response as text.
It would be nice if it could detect msgpack (from Content-Type) or even an option to select the response format, and have it converted to JSON for readability.

@helloanoop helloanoop added enhancement New feature or request good first issue Good for newcomers help wanted Community contribution is welcome labels Oct 4, 2023
@bhavuk2002
Copy link

can you add this as a hacktober? if you possible can you guide / elaborate issue more and provide some possible solution which you have in mind; and dont forget to assign me : )

@helloanoop
Copy link
Contributor

can you add this as a hacktober?

you mean label as hacktober ?

@bhavuk2002
Copy link

bhavuk2002 commented Oct 5, 2023

yeah like such that i can count it in my PR for hacktober?

@ino-josh
Copy link
Author

ino-josh commented Oct 5, 2023

can you add this as a hacktober? if you possible can you guide / elaborate issue more and provide some possible solution which you have in mind; and dont forget to assign me : )

To elaborate:
msgpack is a binary serialization format: "It's like JSON. but fast and small."
Currently bruno cannot handle a response in msgpack format, it essentially crashes. It doesn't actually crash, but the UI disappears, for me at least.
I see two possible solutions, though I don't know which one is better.
One solution is the ability to select a format for the received data (or at least a suggestion: parsing may fail if incorrect).
For example: you tell Bruno the received format is msgpack, but it displays it as JSON.
I suppose you should be able to see the raw binary data in some form as well without it crashing.
Another option would be automatic parsing if the response headers contain Content-Type: application/x-msgpack, although that may be a bit messy just because it is not an official registered MIME type.

@Vinay-Singh-Chauhan
Copy link

Vinay-Singh-Chauhan commented Oct 14, 2023

I want to give it a try , can you assign it to me? @ino-josh

@helloanoop
Copy link
Contributor

We don't have a process to assign issues. You can pick it up and post details as you make progress.
Once ready, please raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Community contribution is welcome long-term-goal module-request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants