Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffJavaM3 signature #2

Open
linuswagner opened this issue Nov 20, 2023 · 1 comment
Open

diffJavaM3 signature #2

linuswagner opened this issue Nov 20, 2023 · 1 comment

Comments

@linuswagner
Copy link

Currently, the signature of diffJavaM3 and diffM3 takes a location (identifier) and a list of metaModels. It then calculates the difference between the first model in the list and the union of the others.

The choice of the list seems questionable: The order of the elements after the first one does not matter. Developers need to know that in order to properly use the method.

It seems more logical to me to have this function written with three parameters:

  • id
  • M3 to compare against
  • set of M3s to form diff with

This then makes it explicit that the order of the other models does not work and it also makes the signature closer to composeM3, which is conceptually similar.

@jurgenvinju
Copy link
Member

You're right. Let's make it a function with two M3 model parameters. Then if someone needs a union as the second parameter they can first use composeM3 for that.

@jurgenvinju jurgenvinju transferred this issue from usethesource/rascal Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants