-
Notifications
You must be signed in to change notification settings - Fork 3
data: add support for Relic Data and new Ranged Enchantments (PR #8015) #74
Copy link
Copy link
Open
Labels
data parsingTasks related to the ingestion and mapping of raw game JSONTasks related to the ingestion and mapping of raw game JSONenhancementNew feature or requestNew feature or requestlogicImplementation of application-specific rules, calculations, or data-driven behaviors.Implementation of application-specific rules, calculations, or data-driven behaviors.
Description
Summary
Add support for game relic data and specifically handle 6 new gun-related enchantments introduced in Cataclysm-BN PR #8015 (cataclysmbn/Cataclysm-BN#8015).
(RANGED_DISPERSION, RANGED_DAMAGE_BULLET, RANGED_ARMOR_PENETRATION, RANGED_RANGE, RANGED_RECOIL, RANGED_RELOAD_TIME).
Context
- Data layer:
src/data.tsandsrc/types.ts(need to definerelic_dataand its sub-structures). - UI layer:
src/types/Item.svelteand a newsrc/types/item/RelicInfo.sveltecomponent.
Impact
Wiki users will be able to see the magical/passive effects of relic items and weapons, which are currently hidden.
Severity
Low - relic_data is not used in main game
Steps to reproduce
- View a weapon or armor that contains
relic_data(e.g. from the nightly build). - Note that no information about passive enchantments is displayed in the item details.
Tech details
The PR #8015 adds specialized gun enchantments. Implementation requires:
- Updating
ItemBasicInfoinsrc/types.ts. - Creating a specialized renderer for
passive_effectsinrelic_data. - Mapping the 6 new enchantment keys to human-readable strings.
- Correctly displaying
add(flat) andmultiply(percentage) modifiers.
Examples
"relic_data": {
"passive_effects": [
{
"has": "WORN",
"condition": "ALWAYS",
"values": [
{ "value": "RANGED_DISPERSION", "add": -200 },
{ "value": "RANGED_DAMAGE_BULLET", "add": 15 },
{ "value": "RANGED_RELOAD_TIME", "multiply": -0.3 }
]
}
]
}Acceptance criteria
-
RelicDataschema is implemented insrc/types.ts. -
Item.sveltedisplays a "Passive Effects" section for items withrelic_data. - The display shows the trigger condition (e.g., "While worn").
- The six new ranged combat enchantments are rendered with localized labels.
- Modifiers are formatted correctly (+/- for flat, % for multipliers).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
data parsingTasks related to the ingestion and mapping of raw game JSONTasks related to the ingestion and mapping of raw game JSONenhancementNew feature or requestNew feature or requestlogicImplementation of application-specific rules, calculations, or data-driven behaviors.Implementation of application-specific rules, calculations, or data-driven behaviors.