Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging #8

Open
uatach opened this issue Aug 9, 2018 · 1 comment
Open

logging #8

uatach opened this issue Aug 9, 2018 · 1 comment
Assignees
@uuazed

Comments

@uatach
Copy link

uatach commented Aug 9, 2018

I find it kind of weird to pass a verbosity level on NumerAPI constructor, usually for a lib is recommended to attach a NullHandler [1] and let the consumer configure it.

[1] https://docs.python.org/3.6/howto/logging.html#configuring-logging-for-a-library
@uuazed
Copy link
Owner

uuazed commented Aug 10, 2018

Yes, I agree that the current logging setup is suboptimal. Thanks for the pointer to that doc, looks like the way forward.

@uuazed uuazed self-assigned this Aug 10, 2018
@uatach uatach mentioned this issue Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uuazed uuazed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed logging init from NumerAPI class
2 participants
@uatach @uuazed