Skip to content

hashsum: Should Windows/Cygwin accept --check --binary/--text? #10071

@oech3

Description

@oech3

When I was looking #9992 , I saw a strange cfg block for Windows:

// on Windows, allow --binary/--text to be used with --check
// and keep the behavior of defaulting to binary
#[cfg(not(windows))]
{
let text_flag = matches.get_flag("text");
let binary_flag = matches.get_flag("binary");
if binary_flag || text_flag {
return Err(ChecksumError::BinaryTextConflict.into());
}
}

But I think it is not too many useful considering we decided to ignore --text on Cygwin.
Also if Cygwin people want to be same Linux, it cause a confusion on MSYS having both packages. Can we just drop it or do same things for cygwin?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions