Use spacewalk-hostname-rename from uyuni-update-config service

Watch out for UYUNI_HOSTNAME value change before starting services and
rename the server if needed. (bsc#1229825)

In order to achieve this, the spacewalk-hostname-rename script had to be
cleaned up.

Author: cbosdo

spacewalk/admin/spacewalk-admin.changes.cbosdo.hostname-rename

@@ -0,0 +1 @@
+- Fix spacewalk-hostname-rename with containers (bsc#1229825)

spacewalk/admin/uyuni-update-config

@@ -21,8 +21,9 @@ from spacewalk.server import rhnSQL
 
 def run_uyuni_configfiles_sync():
     if not os.path.isfile("/usr/bin/uyuni-configfiles-sync"):
-        return
+        return 0
 
+    exitCode = 0
     result = subprocess.run(
         ["/usr/bin/uyuni-configfiles-sync", "sync"],
         stdout=subprocess.PIPE,
@@ -39,7 +40,8 @@ def run_uyuni_configfiles_sync():
             "Failed to synchronize files to persistent volumes. Aborting!\n"
         )
         sys.stdout.flush()
-        sys.exit(1)
+        exitCode = 1
+    return exitCode
 
 
 def move_config_to_db():
@@ -186,14 +188,32 @@ def change_billing_data_service():
         sys.stdout.write("billing-data-service sysconfig: changed LISTEN address\n")
 
 
+def hostname_check():
+    result = subprocess.run(
+        ["/usr/bin/spacewalk-hostname-rename"],
+        stdout=subprocess.PIPE,
+        stderr=subprocess.STDOUT,
+        encoding="utf-8",
+        check=False,
+    )
+
+    if result.returncode:
+        sys.stdout.write("Failed to rename the server\n")
+    if result.stdout:
+        sys.stdout.write(f"{result.stdout}\n")
+    sys.stdout.flush()
+    return result.returncode
+
+
 def main():
-    run_uyuni_configfiles_sync()
+    exitCode = run_uyuni_configfiles_sync()
     init_scc_login()
     import_suma_gpg_keyring()
     copy_ca()
     move_config_to_db()
     change_billing_data_service()
-
+    exitCode = max(hostname_check(), exitCode)
+    return exitCode
 
 if __name__ == "__main__":
     sys.exit(abs(main() or 0))

spacewalk/admin/uyuni-update-config.service

@@ -1,8 +1,9 @@
 [Unit]
 Description=Uyuni update config
-Before=uyuni-check-database.service tomcat.service apache2.service rhn-search.service taskomatic.service postfix.service
+Before=uyuni-check-database.service cobblerd.service tomcat.service apache2.service rhn-search.service taskomatic.service postfix.service
 
 [Service]
+PassEnvironment=UYUNI_HOSTNAME
 ExecStart=/usr/sbin/uyuni-update-config
 Type=oneshot
 RemainAfterExit=yes