From e90468d69f01f8e4a7a197e7d039575ec4a28475 Mon Sep 17 00:00:00 2001 From: Gabriel Cruz Date: Tue, 5 May 2026 11:09:42 -0300 Subject: [PATCH] fix(daily): cover traffic leaking channels --- tests/libp2p/mix/component/test_cover_traffic.nim | 10 +++++----- tests/libp2p/mix/utils.nim | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/libp2p/mix/component/test_cover_traffic.nim b/tests/libp2p/mix/component/test_cover_traffic.nim index feee4840c8..a5bcc2f824 100644 --- a/tests/libp2p/mix/component/test_cover_traffic.nim +++ b/tests/libp2p/mix/component/test_cover_traffic.nim @@ -77,16 +77,16 @@ suite "Cover Traffic - Integration": asyncTest "slot exhaustion blocks local send, epoch reset unblocks": let nodes = await setupMixNodes(5) - startAndDeferStop(nodes) + let (destNode, _) = await setupDestNode(NoReplyProtocol.new()) + await startNodes(nodes) + defer: + await stopNodes(nodes) + await stopDestNode(destNode) let ct = ConstantRateCoverTraffic.new(totalSlots = 2, useInternalEpochTimer = false) ct.onEpochChange(1) nodes[0].coverTraffic = Opt.some(CoverTraffic(ct)) - let (destNode, _) = await setupDestNode(NoReplyProtocol.new()) - defer: - await stopDestNode(destNode) - let incoming = newAsyncQueue[seq[byte]]() # First send succeeds (claims 1 of 2 slots) diff --git a/tests/libp2p/mix/utils.nim b/tests/libp2p/mix/utils.nim index f11258c6b4..3dbe90b7c8 100644 --- a/tests/libp2p/mix/utils.nim +++ b/tests/libp2p/mix/utils.nim @@ -154,7 +154,7 @@ proc new*(T: typedesc[NoReplyProtocol]): NoReplyProtocol = ReceivedMessage(connPeerId: conn.peerId, data: buffer) ) except LPStreamError: - raiseAssert "should not happen" + discard finally: await conn.close()