@@ -4583,8 +4583,8 @@ fn test_drop_constraints() {
4583
4583
}
4584
4584
4585
4585
#[ test]
4586
- fn test_semantic_view_all_variants_should_pass ( ) {
4587
- let test_cases = [
4586
+ fn test_semantic_view ( ) {
4587
+ let valid_sqls = [
4588
4588
( "SELECT * FROM SEMANTIC_VIEW(model)" , None ) ,
4589
4589
(
4590
4590
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1, dim2)" ,
@@ -4634,7 +4634,7 @@ fn test_semantic_view_all_variants_should_pass() {
4634
4634
) ,
4635
4635
] ;
4636
4636
4637
- for ( input_sql, expected_sql) in test_cases {
4637
+ for ( input_sql, expected_sql) in valid_sqls {
4638
4638
if let Some ( expected) = expected_sql {
4639
4639
// Test that non-canonical order gets normalized
4640
4640
let parsed = snowflake ( ) . parse_sql_statements ( input_sql) . unwrap ( ) ;
@@ -4644,10 +4644,7 @@ fn test_semantic_view_all_variants_should_pass() {
4644
4644
snowflake ( ) . verified_stmt ( input_sql) ;
4645
4645
}
4646
4646
}
4647
- }
4648
4647
4649
- #[ test]
4650
- fn test_semantic_view_invalid_queries_should_fail ( ) {
4651
4648
let invalid_sqls = [
4652
4649
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 INVALID inv1)" ,
4653
4650
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 DIMENSIONS dim2)" ,
@@ -4658,18 +4655,15 @@ fn test_semantic_view_invalid_queries_should_fail() {
4658
4655
let result = snowflake ( ) . parse_sql_statements ( sql) ;
4659
4656
assert ! ( result. is_err( ) , "Expected error for invalid SQL: {}" , sql) ;
4660
4657
}
4661
- }
4662
4658
4663
- #[ test]
4664
- fn test_semantic_view_ast_structure ( ) {
4665
- let sql = r#"SELECT * FROM SEMANTIC_VIEW(
4659
+ let ast_sql = r#"SELECT * FROM SEMANTIC_VIEW(
4666
4660
my_model
4667
4661
DIMENSIONS DATE_PART('year', date_col), region_name
4668
4662
METRICS orders.revenue, orders.count
4669
4663
WHERE active = true
4670
4664
) AS model_alias"# ;
4671
4665
4672
- let stmt = snowflake ( ) . parse_sql_statements ( sql ) . unwrap ( ) ;
4666
+ let stmt = snowflake ( ) . parse_sql_statements ( ast_sql ) . unwrap ( ) ;
4673
4667
match & stmt[ 0 ] {
4674
4668
Statement :: Query ( q) => {
4675
4669
if let SetExpr :: Select ( select) = q. body . as_ref ( ) {
0 commit comments