Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/topics/benchmark.md has outdated info #139

Closed
stockholmux opened this issue May 31, 2024 · 0 comments · Fixed by #153
Closed

/topics/benchmark.md has outdated info #139

stockholmux opened this issue May 31, 2024 · 0 comments · Fixed by #153

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91), I found the following issues with /topics/benchmark.md

At this game, Intel CPUs are currently the winners. It is not uncommon to get only half the performance on an AMD Opteron CPU compared to similar Nehalem EP/Westmere EP/Sandy Bridge Intel CPUs with Valkey

All of this old/irrelevant information. 'AMD Opteron' was discontinued in 2017, 'Nehalem' in 2011, 'Sandy Bridge' in 2013. It should be deleted.
zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
@zuiderkwast
Delete references to old CPUs in benchmark.md, fixes valkey-io#139
acf007f 
Signed-off-by: Viktor Söderqvist <[email protected]>
@zuiderkwast zuiderkwast mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc review fixes zuiderkwast/valkey-doc
1 participant
@stockholmux