Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/admin.md has outdated info #96

Closed
stockholmux opened this issue May 24, 2024 · 1 comment · Fixed by #197
Closed

/topics/admin.md has outdated info #96

stockholmux opened this issue May 24, 2024 · 1 comment · Fixed by #197

Comments

@stockholmux
Copy link
Member

In reviewing /topics/admin.md for #91, I noticed the following things:

  1. References to testing in FreeBSD / OpenBSD / OS X; to my knowledge this testing hasn't be done for Valkey.
  2. Antirez's blog is references for "this attack". I think the attack in question really only relevant to Redis 3.2 or below.
  3. Under the section "Running Valkey on EC2" it says "Do not use old instance families. For example, use m3.medium with HVM instead of m1.medium with PV." m3 is now a previous generation instance.
  4. It says CONFIG SET slave-read-only no
@zuiderkwast
Copy link
Contributor

References to testing in FreeBSD / OpenBSD / OS X; to my knowledge this testing hasn't be done for Valkey.

We have FreeBSD and macOS in our Daily CI.

For the other BSDs in the list, to which we can add NetBSD and DragonFlyBSD, we have had several contributions, so I'm pretty sure we have at least one person that has tested them:

Antirez's blog is references for "this attack". I think the attack in question really only relevant to Redis 3.2 or below.

Deleting these sentences.

Under the section "Running Valkey on EC2" it says "Do not use old instance families. For example, use m3.medium with HVM instead of m1.medium with PV." m3 is now a previous generation instance.

Deleting this bullet.

It says CONFIG SET slave-read-only no

Already fixed in some other PR.

zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Dec 10, 2024
Signed-off-by: Viktor Söderqvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants